This repository was archived by the owner on May 14, 2025. It is now read-only.
Add support for MySQL 5/8 via MariaDB driver #5071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use FlywayVendorReplacingEnvironmentPostProcessor to replace {vendor} in spring.flyways.locations
* Add back in the MySQL schema
* Use vendor (mysql) not driver in flyway configuration customizer
See spring-attic#4887
onobc
force-pushed
the
cbono-flway-vendor-replace-epp
branch
from
0aa0cff to
f08096b
Compare
onobc
changed the title
cppwfs
reviewed
Sep 1, 2022
| @@ -0,0 +1,321 @@ | |||
| /* | |||
| * Copyright 2019-2022 the original author or authors. | |||
There was a problem hiding this comment.
Nitpick but it would be 2022-2022.
I had to pick on something ;-)
There was a problem hiding this comment.
Yep - fair enough. All of these files were actually here since 2019 and recently deleted like 6 months ago. I just resurrected these from git so was unsure if we should leave the start dates like they were? Thoughts?
| * @author Glenn Renfro | ||
| * @author Chris Bono | ||
| * | ||
| * @since 2.7 |
There was a problem hiding this comment.
Ditto as the above outdated copyright range.
| @@ -0,0 +1,269 @@ | |||
| create table if not exists hibernate_sequence ( | |||
There was a problem hiding this comment.
I know this is how it is setup. Just seems odd that the skipper migration is in dataflow and not in skipper.
There was a problem hiding this comment.
Yeh it is a bit odd but it expects that SCDF "goes first" and if it does then it must provide the schemas.
...amework/cloud/dataflow/server/config/FlywayVendorReplacingEnvironmentPostProcessorTests.java
Show resolved
Hide resolved
onobc
changed the title
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4887