Skip to content
This repository was archived by the owner on May 14, 2025. It is now read-only.

Ensure PackageMetadata is created with SafeConstructor #5871

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

cppwfs
Copy link
Contributor

@cppwfs cppwfs commented Jul 18, 2024

Use root provided to determine type of conversion to use.

  • Added tests when root is specified
  • Added tests for builder

Remove PackagMetadataBuilder, it is not needed

Update default constructors to use the safe constructor.

Use root provided to determine type of conversion to use.

* Added tests when root is specified
* Added tests for builder

Remove PackagMetadataBuilder, it is not needed

Update default constructors to use the safe constructor.
@cppwfs cppwfs added this to the 3.14 milestone Jul 18, 2024
@cppwfs cppwfs requested a review from onobc July 18, 2024 15:07
Copy link
Contributor

@onobc onobc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @cppwfs - thanks for the improvement.

@onobc onobc modified the milestones: 3.14, 2.11.4 Jul 18, 2024
@onobc onobc added the area/dependencies Belongs project dependencies label Jul 18, 2024
@onobc onobc merged commit d5380e2 into spring-attic:main Jul 18, 2024
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/dependencies Belongs project dependencies
Development

Successfully merging this pull request may close these issues.

2 participants