Add task thin executions by name and fix missing docs. #5994
Conversation
…ions. Add task thin executions by name. Update api-guide.adoc with links to generated documentation. Modify TaskCommands to use thin executions since it provides the data required. Removed duplicate entries from api docs. Fixes spring-attic#5991 Fixes spring-attic#5973
|
Hmm... Looks like the build failed with the following test failure: RootControllerTests.rootControllerResponse:71 |
.github/workflows/ci-pr.yml
Outdated
| @@ -17,7 +17,7 @@ jobs: | |||
| shell: bash | |||
| timeout-minutes: 75 | |||
| run: | | |||
| ./mvnw -B -s .github/settings.xml -Pdocs clean install --no-transfer-progress | |||
| ./mvnw -B -s .github/settings.xml -Pfull,docs clean install --no-transfer-progress | |||
There was a problem hiding this comment.
Do we want to generate full docs on a PR build?
There was a problem hiding this comment.
We want to catch errors in a PR.
There was a problem hiding this comment.
Probably want to put this in another PR, since it relates to a process change.
Added test for |
|
Thank you for verifying. I pulled down the latest and rebuilt the project and now seeing something a different, investigating. |
…not found. Provide task/execution and thin executions by name test when task is not defined and where it is defined. Removed excess `andDo(print())` from tests.
|
Looks like we picked up a CI test failure. |
…tasks/thinexecutions name search scenarios.
|
|
||
|
|
||
|
|
||
| [[api-guide-resources-task-thin-executions-list-by-name-request-parameters]] |
There was a problem hiding this comment.
Can you verify that the request parameters are being generated properly. I'm seeing,
Unresolved directive in api-guide.adoc - include::/Users/grenfro/project/spring-cloud-dataflow/spring-cloud-dataflow-docs/../spring-cloud-dataflow-classic-docs/target/generated-snippets/task-executions-documentation/list-task-thin-executions-by-name/request-parameters.adoc[]
There was a problem hiding this comment.
Found the issue that caused this. Created #6008 to record it. I'll fix all of them.
This commit is a back port of "Add task thin executions by name and fix missing docs" (#5994). - changes TaskTemplate to use task/thinexecutions instead of task/executions - adds task thin executions by name - updates api-guide.adoc with links to generated documentation - modifies TaskCommands to use thin executions since it provides the data required. Resolves #5995
Change TaskTemplate to use task/thinexecutions instead of task/executions.
Add task thin executions by name.
Update api-guide.adoc with links to generated documentation.
Modify TaskCommands to use thin executions since it provides the data required.
Removed duplicate entries from api docs.
Fixes #5991
Fixes #5973