Added query for composed-task-runner status. #5792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#Fixes 5782
cppwfs
requested changes
May 2, 2024
| this.resourceAssembler = new TaskExecutionThinResourceAssembler(); | ||
| } | ||
|
|
||
| @GetMapping(produces = "application/json") | ||
| @ResponseStatus(HttpStatus.OK) | ||
| public PagedModel<TaskExecutionThinResource> listTasks(Pageable pageable, PagedResourcesAssembler<AggregateTaskExecution> pagedAssembler) { | ||
| return pagedAssembler.toModel(explorer.findAll(pageable, true), resourceAssembler); | ||
| Page<AggregateTaskExecution> page = explorer.findAll(pageable, true); | ||
| taskJobService.populateComposeTaskRunnerStatus(page.getContent()); |
There was a problem hiding this comment.
Have we determined the cost of running the retrieval of the CTR status for the results set?
There was a problem hiding this comment.
I compared before and after timings from org.springframework.cloud.dataflow.integration.test.tasks.TaskExecutionQueryIT
I added index in parent_execution_id and now the difference is hardly noticeable.
| execution.setCtrTaskStatus(ctrStatus); | ||
| }); | ||
| } | ||
| LOG.info("updated {} ctr statuses", updated.get()); |
|
|
||
| @RequestMapping(value = "", method = RequestMethod.GET, params = "name") | ||
| @ResponseStatus(HttpStatus.OK) | ||
| public PagedModel<TaskExecutionThinResource> retrieveTasksByName(@RequestParam("name") String taskName, |
There was a problem hiding this comment.
Do we have a test to verify the population of the status?
Added check for taskExecutionStatus on task execution list.
cppwfs
requested changes
May 3, 2024
| @@ -313,6 +313,10 @@ public void stopJobExecution(long jobExecutionId, String schemaTarget) throws No | |||
| logger.info("stopped:{}:{}:status={}", jobExecutionId, schemaTarget, status); | |||
| } | |||
|
|
|||
| @Override | |||
| public void populateComposeTaskRunnerStatus(Collection<AggregateTaskExecution> taskExecutions) { | |||
There was a problem hiding this comment.
We probably want to add a test here as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5782