User needs ability to specify app version when creating schedule #5830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update allows user to specify version.label=<version.number> Tests were also updated because the original settings assumed that the appregistry was real instance instead of being mocked. Thus the find would always return null. And in this case the tests returned a false positive. Now that the mocks are in place it excercises all the code. Also added explicit test if user does not set the version number. Some of the tests do this, but wanted an explicit test to verify this. resolves spring-cloud#5705
|
Squashed Merged. @corneil Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update allows user to specify
version.label=<version.number>.Previously the version number specified was not used when searching the registry for the resource, thus the default version was used.
Tests were also updated because the original settings assumed that the
AppRegistrationwas a real instance instead of being mocked. Thus thefindwould always returnnull.And in this case the tests returned a false positive. Now that the mocks are in place it exercises all the code.
Also added explicit test if user does not set the version number. Some of the tests do this, but wanted an explicit test to verify this.
resolves #5705