Skip to content

Update Spring Cloud AWS dependency in Kinesis binder #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rbraeunlich opened this issue Nov 30, 2022 · 4 comments
Closed

Update Spring Cloud AWS dependency in Kinesis binder #181

rbraeunlich opened this issue Nov 30, 2022 · 4 comments
Labels
enhancement

Comments

@rbraeunlich
Copy link

Hi everyone,

the Kinesis binder still depends on Spring Cloud AWS 2.4.0. As I can see the 4.0.0 version of your projects all depend on the latest Spring version (6.0.0). Therefore, the Kinesis binder should use the latest Spring Cloud AWS version, which is 3.0.0-M3

Cheers,
Ronny
@artembilan
Copy link
Member

We cannot do that until Spring Cloud AWS 3.0.0 is released.
More over we still cannot do that until Spring Integration AWS 3.0.0 is released and that one has some blockers: spring-projects/spring-integration-aws#155

@rbraeunlich
Copy link
Author

Hi @artembilan
is there any chance that you'll provide a Milestone or RC release?

@artembilan
Copy link
Member

Sorry, for what?
Spring Integration AWS currently is based on Spring Cloud AWS 2.4.x.
As I said before: we cannot move it to Spring Cloud AWS 3.0.0 because there are some blockers from other dependencies which are not supporting AWS SDK v2 yet.
And some of them are really AWS projects by itself.
If you are looking for Kinesis Binder compatible with Spring Boot 3.0, then yes, we will look into that in the nearest future, but again: it is not going to be based on Spring Cloud AWS 3.0.0 and therefore AWS SDK v2 yet.
Right now we are in discussion to move Kinesis Binder source code from this Spring Cloud Stream repo back its own and do the rest of support for a new version already over there.
The point is exactly because we are stuck at the moment with those blockers for moving to AWS SDK v2 fully.

sobychacko referenced this issue in sobychacko/spring-cloud-stream Nov 30, 2022
@sobychacko
Disconnect Kinesis binder from the build
02b3b8e 
- Kinesis binder depends on spring-cloud-aws library which only becomes available
  after the spring-cloud (2022) release that includes Spring Cloud Stream release.
  This creates a cycle and thus we cannot include Kinesis binder release as part
  of the Spring Cloud Stream release train.

  See this issue for more details: https://github.com/spring-cloud/spring-cloud-stream/issues/2572

- Subsequently, we will remove the source code for Kinesis binder from core SCSt repostiroy and move
  it into it's own space (as it was before).
@artembilan artembilan transferred this issue from spring-cloud/spring-cloud-stream Jan 4, 2023
artembilan added a commit that referenced this issue Mar 24, 2023
@artembilan
GH-181, GH-182, GH-183: Migrate to AWS SDK v2
fba430a 
Fixes #181
Fixes #182
Fixes #183

* Upgrade to the latest dependencies
* Remove `SpringDynamoDBAdapterClient` since the DynamoDB Kinesis adapter
is not recommended by AWS per se.
* Fix docs to reflect new version logic
* Remove `@Import({ContextCredentialsAutoConfiguration.class, ContextRegionProviderAutoConfiguration.class})`
and fully rely on the auto-configuration
@artembilan
Copy link
Member

Fixed via fba430a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@artembilan @rbraeunlich