Skip to content

Update Task Tests to use ImportAutoConfiguration #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cppwfs opened this issue Aug 15, 2018 · 0 comments
Closed

Update Task Tests to use ImportAutoConfiguration #440

cppwfs opened this issue Aug 15, 2018 · 0 comments
Assignees
@cppwfs
Labels
test-coverage
Milestone
2.1.0.M1

Comments

@cppwfs
Copy link
Collaborator

cppwfs commented Aug 15, 2018

Currently we use SpringApplicationBuilder with tests that require AutoConfiguration. This form of testing is incorrect in that it does not handle the AutoConfiguration stage correctly.
@cppwfs cppwfs self-assigned this Aug 15, 2018
cppwfs added a commit to cppwfs/spring-cloud-task that referenced this issue Aug 15, 2018
@cppwfs
Update Task to BOOT 2.1.M1
1cc6f61 
Migrating to use ApplicationContextRunner or ImportAutoConfiguration with SpringApp.run, instead of SpringApplicationBuilder, because builder does not handle AutoConfiguration properly

SimpleTaskAutoConfiguration now has an annotation AutoConfigureBefore the BatchTaskAutoConfig so that it is processed prior.  THis is so that that BatchTaskAutoConfig can create the appropriate beans

SimpleTaskAutoConfiguration has new annotations so that it is AutoConfigured after BindingServiceConfiguration and after SimpleTaskAutoConfiguration.  This is so that it does not attempt to start emitting messages before stream is ready and it can create the appropriate beans after SimpleTaskAutoConfiguration has run.

Renamed SimpleTaskConfiguration to SimpleTaskAutoConfiguration.

Task version updated to  2.1.0

Added missing headers

Resolves spring-cloud#439
Resolves spring-cloud#440

polish

Updated documentation.

Deprecated EnableTask

Added ability to disable Task autoconfiguration.

Removed @EnableTask from tests
cppwfs added a commit to cppwfs/spring-cloud-task that referenced this issue Aug 15, 2018
@cppwfs
Update Task to BOOT 2.1.M1
e7f2a57 
Migrating to use ApplicationContextRunner or ImportAutoConfiguration with SpringApp.run, instead of SpringApplicationBuilder, because builder does not handle AutoConfiguration properly

SimpleTaskAutoConfiguration now has an annotation AutoConfigureBefore the BatchTaskAutoConfig so that it is processed prior.  THis is so that that BatchTaskAutoConfig can create the appropriate beans

SimpleTaskAutoConfiguration has new annotations so that it is AutoConfigured after BindingServiceConfiguration and after SimpleTaskAutoConfiguration.  This is so that it does not attempt to start emitting messages before stream is ready and it can create the appropriate beans after SimpleTaskAutoConfiguration has run.

Renamed SimpleTaskConfiguration to SimpleTaskAutoConfiguration.

Task version updated to  2.1.0

Added missing headers

Updated documentation.

Deprecated EnableTask

Added ability to disable Task autoconfiguration.

Removed @EnableTask from tests

Resolves spring-cloud#439
Resolves spring-cloud#440
@cppwfs cppwfs mentioned this issue Aug 15, 2018
Closed
@cppwfs cppwfs added in pr and removed in progress labels Aug 15, 2018
@sabbyanandan sabbyanandan added this to the 2.1.0.M1 milestone Aug 29, 2018
cppwfs added a commit to cppwfs/spring-cloud-task that referenced this issue Oct 25, 2018
@cppwfs
Update Task to BOOT 2.1.M1
4b532bc 
Migrating to use ApplicationContextRunner or ImportAutoConfiguration with SpringApp.run, instead of SpringApplicationBuilder, because builder does not handle AutoConfiguration properly

SimpleTaskAutoConfiguration now has an annotation AutoConfigureBefore the BatchTaskAutoConfig so that it is processed prior.  THis is so that that BatchTaskAutoConfig can create the appropriate beans

SimpleTaskAutoConfiguration has new annotations so that it is AutoConfigured after BindingServiceConfiguration and after SimpleTaskAutoConfiguration.  This is so that it does not attempt to start emitting messages before stream is ready and it can create the appropriate beans after SimpleTaskAutoConfiguration has run.

Renamed SimpleTaskConfiguration to SimpleTaskAutoConfiguration.

Task version updated to  2.1.0

Added missing headers

Updated documentation.

Deprecated EnableTask

Added ability to disable Task autoconfiguration.

Removed @EnableTask from tests

Resolves spring-cloud#439
Resolves spring-cloud#440
cppwfs added a commit to cppwfs/spring-cloud-task that referenced this issue Oct 26, 2018
@cppwfs
Update Task to BOOT 2.1.M1
906df74 
Migrating to use ApplicationContextRunner or ImportAutoConfiguration with SpringApp.run, instead of SpringApplicationBuilder, because builder does not handle AutoConfiguration properly

SimpleTaskAutoConfiguration now has an annotation AutoConfigureBefore the BatchTaskAutoConfig so that it is processed prior.  THis is so that that BatchTaskAutoConfig can create the appropriate beans

SimpleTaskAutoConfiguration has new annotations so that it is AutoConfigured after BindingServiceConfiguration and after SimpleTaskAutoConfiguration.  This is so that it does not attempt to start emitting messages before stream is ready and it can create the appropriate beans after SimpleTaskAutoConfiguration has run.

Renamed SimpleTaskConfiguration to SimpleTaskAutoConfiguration.

Task version updated to  2.1.0

Added missing headers

Updated documentation.

Deprecated EnableTask

Added ability to disable Task autoconfiguration.

Removed @EnableTask from tests

Resolves spring-cloud#439
Resolves spring-cloud#440
@mminella mminella removed the in pr label Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cppwfs cppwfs

Labels
test-coverage
Projects
None yet
Milestone
2.1.0.M1
Development

No branches or pull requests
3 participants
@mminella @cppwfs @sabbyanandan