Skip to content

TaskJobLauncherCommandLineRunner needs to use BatchStatus and not ExitStatus to determine Job Success #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cppwfs opened this issue Oct 25, 2018 · 0 comments
Closed

TaskJobLauncherCommandLineRunner needs to use BatchStatus and not ExitStatus to determine Job Success #466

cppwfs opened this issue Oct 25, 2018 · 0 comments
Labels
type: bug
Milestone
2.1.0.M1

Comments

@cppwfs
Copy link
Collaborator

cppwfs commented Oct 25, 2018

We need to use BatchStatus to determine if the JobExecution successfully terminated in the TaskJobLauncherCommandLineRunner. https://github.com/spring-cloud/spring-cloud-task/blob/master/spring-cloud-task-batch/src/main/java/org/springframework/cloud/task/batch/handler/TaskJobLauncherCommandLineRunner.java#L169
@cppwfs cppwfs added this to the 2.1.0.M1 milestone Oct 25, 2018
@cppwfs cppwfs mentioned this issue Oct 25, 2018
Closed
cppwfs added a commit to cppwfs/spring-cloud-task that referenced this issue Oct 26, 2018
@cppwfs
Updated based on code review
6c9bce9 
* term millis removed from class attributes and moved to docs
* timeout attributes removed from TaskJobLauncherCommandLinerRunnerFactory Bean and TaskJobLauncherCommandLineRunner
* TaskBatchTest moved to configuration package
* Documentation updated
* pom.xml reset
* rebased conflicts resolved
* TaskJobLauncherCommandLineRunner uses BatchStatus instead of exitCode
to determine if a Job has failed.

resolves spring-cloud#466
@cppwfs cppwfs added in pr and removed ready labels Oct 26, 2018
cppwfs added a commit to cppwfs/spring-cloud-task that referenced this issue Oct 29, 2018
@cppwfs
Updated TaskJobLauncherCommandLineRunner to match what is in Spring B…
7d35e0d 
…oot 2.1.x

The changes to the pom files will need to be removed when Spring Cloud is updated to the latest release.
resolves spring-cloud#466
cppwfs added a commit to cppwfs/spring-cloud-task that referenced this issue Oct 29, 2018
@cppwfs
Updated TaskJobLauncherCommandLineRunner to match what is in Spring B…
2cab222 
…oot 2.1.x

The changes to the pom files will need to be removed when Spring Cloud is updated to the latest release.
resolves spring-cloud#466
@mminella mminella removed the in pr label Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
2.1.0.M1
Development

No branches or pull requests
2 participants
@mminella @cppwfs