Add client credentials authentication filter #78
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tomvandenberge This looks good - the files in this PR is what I was expecting. I will review this shortly. In the meantime, I would recommend checking out this post on merging vs. rebasing. |
jgrandja
requested changes
May 21, 2020
There was a problem hiding this comment.
Thanks for the updates @tomvandenberge and apologies for the delay in review. Please see the review comments.
...ork/security/oauth2/server/authorization/authentication/OAuth2ClientAuthenticationToken.java
Outdated
Show resolved
Hide resolved
...ork/security/oauth2/server/authorization/authentication/OAuth2ClientAuthenticationToken.java
Outdated
Show resolved
Hide resolved
samples/boot/minimal/spring-authorization-server-samples-boot-minimal.gradle
Show resolved
Hide resolved
samples/boot/minimal/src/main/java/sample/ClientCredentialsAuthenticationFilter.java
Outdated
Show resolved
Hide resolved
samples/boot/minimal/src/main/java/sample/ClientCredentialsAuthenticationFilter.java
Outdated
Show resolved
Hide resolved
samples/boot/minimal/src/main/java/sample/ClientCredentialsAuthenticationFilter.java
Outdated
Show resolved
Hide resolved
samples/boot/minimal/src/test/java/sample/ClientCredentialsAuthenticationFilterTest.java
Outdated
Show resolved
Hide resolved
jgrandja
added
status: duplicate
|
Thanks for all the updates @tomvandenberge. This is now in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5 .
I hope this PR work better than my previous attempt ;-) Thanks @jgrandja and @dfcoffin for your support.