Skip to content

Add a Client Credentials Authentication Filter #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rwinch opened this issue Apr 9, 2020 · 5 comments
Closed

Add a Client Credentials Authentication Filter #5

rwinch opened this issue Apr 9, 2020 · 5 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@rwinch
Copy link
Member

rwinch commented Apr 9, 2020

When the token endpoint from gh-3 is invoked, we will need to validate client credentials (we can add other grant types later). For this issue, we can use a hard coded client credentials. The idea is to keep this as simple as possible. We should validate every aspect of the client credentials grant type.

We should produce tests that verify the behaviour

@rwinch rwinch added this to the 0.0.1 milestone Apr 9, 2020
@jgrandja jgrandja added the type: enhancement A general enhancement label Apr 16, 2020
@paurav-munshi
Copy link
Contributor

@rwinch @jgrandja If no one is working on this, I can start working on it.

@rwinch
Copy link
Member Author

rwinch commented Apr 20, 2020

Thanks for volunteering @paurav-munshi! The issue is yours

@tomvandenberge
Copy link

@paurav-munshi I have been working on this issue, too, and missed your message. I've created a filter and tests. Please let me know if you want me to create a pull request; I don't want to hijack your issue ;-)

@paurav-munshi
Copy link
Contributor

I have been working on this but not completed it. If you think you are done, please create a PR. That should be fine.

@paurav-munshi
Copy link
Contributor

@rwinch @jgrandja

I have created a draft pull request for this issue. I would request you to review this PR and let me know if I am putting the correct thought process and also provide your inputs around it. Please note that this is still a work in progress. I have yet to write the test cases.

The idea is that to create a OAuth related templated filter which could be instantiated by composing various pieces in a configuration. So the same class can be instantiated for Client Credentials as well as authorization_code grant type, by providing different composable compoenents.

@tomvandenberge Feel free to share your work too especially if its on different line of thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
5 participants