2.7: Changes to Auto-configuration #156

[ijusti]

No description provided.

[pivotal-cla]

@ijusti Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

[pivotal-cla]

@ijusti Thank you for signing the Contributor License Agreement!

[fabapp2]

Hi @ijusti!
I've been on PTO thus the long delay.
Thanks a lot for your contribution and the many beautifications and fixes. Very much appreciated! 🙏
I had a few comments regarding the operation on files and would ask you to provide at least a test for the Action itself.
If you could resolve these comments I'll happily merge your PR.
Thanks again!

[fabapp2]

Could you use e.g. PathPatternMatchingProjectResourceFinder instead?
This would also remove the dependency from Condition to Action and remove the assumption that the resources in the ProjectContext exist as files.

return !context.search(new PathPatternMatchingProjectResourceFinder("**/src/main/resources/META-INF/spring.factories")).isEmpty();

[ijusti]

i need to check that near spring.factories no new file exists

[fabapp2]

You're right, that's a good idea. What about something like this?

return !context.search(new PathPatternMatchingProjectResourceFinder("**/src/main/resources/META-INF/spring.factories")).isEmpty() && 
context.search(new PathPatternMatchingProjectResourceFinder("**/src/main/resources/META-INF/org.springframework.boot.autoconfigure.AutoConfiguration.imports")).isEmpty()

[ijusti]

this good, and I tried to make this way? but there is no spring.factories in context

[ijusti]

something like this, that mean that there is no new imports near spring.factories

return context.search(new PathPatternMatchingProjectResourceFinder("**/src/main/resources/META-INF/spring.factories"))
.stream()
.anyMatch(resource-> context.search(new PathPatternMatchingProjectResourceFinder("resource.path.parent +"org.springframework.boot.autoconfigure.AutoConfiguration.imports")).isEmpty())

[fabapp2]

Ah, I got your valid point here.
I am thinking that if we replace all old with new factories in one go and remove the old ones (or move with MoveFilesAction), there should not be both (old and new) in one project. If this is "guaranteed" we can skip the second part of the check?

You could replace resource.path.parent with resource.getAbsoluetPath().getParent().resolve("org.springframework.boot.autoconfigure.AutoConfiguration.imports") and then use AbsolutePathResourceFinder with this path.

[fabapp2]

Please provide a test for this class.
You can create a synthetic ProjectContext with TestProjectContext helper class.
Run the Action against the created ProjectConetxt and verify the result.
You can have a look at existing tests for examples.

[fabapp2]

You're right, that's a good idea. What about something like this?

return !context.search(new PathPatternMatchingProjectResourceFinder("**/src/main/resources/META-INF/spring.factories")).isEmpty() && 
context.search(new PathPatternMatchingProjectResourceFinder("**/src/main/resources/META-INF/org.springframework.boot.autoconfigure.AutoConfiguration.imports")).isEmpty()

[fabapp2]

Hi @ijusti !
Could you provide the requested changes?
I am sorry if I am pushy here but we'll need this issue (very) soon.
It's no problem if you don't have time, I'd merge what you did and add the requested changes myself then (crediting you as author).
Let me know what works for you?