-
Notifications
You must be signed in to change notification settings - Fork 1.3k
cosmos db entra id support and fixes #2707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cosmos db entra id support and fixes #2707
Conversation
a37a4bd
to
e32efcf
Compare
Signed-off-by: Theo van Kraay <[email protected]>
Signed-off-by: Theo van Kraay <[email protected]>
e258d1c
to
20dafb6
Compare
Signed-off-by: Theo van Kraay <[email protected]>
@TheovanKraay As @markpollack commented on the other issue, we could not verify certain refactoring changes we made due to the lack of access to a proper CosmosDB environment. Apologies for that bug you mentioned. Quick question: Did you get a chance to verify all the tests including the IT's on yoru CosmosDB environment? Thanks! |
For this PR I have run all the ITs and they pass (using Entra ID with appropriate level of access to the Cosmos DB resources). |
@TheovanKraay How do we set up the Entra ID and the access levels? Any docs for that? |
Documentation can be found here: https://learn.microsoft.com/en-us/azure/cosmos-db/nosql/security/how-to-grant-data-plane-role-based-access?tabs=built-in-definition%2Ccsharp&pivots=azure-interface-cli I've left the capability to use key based auth there in the code (since we have not strictly deprecated or retired it ) but I did not include tests or docs for it because we generally don't recommend it (and it will be removed eventually). |
Merged via e723371. |
@TheovanKraay The version we use for Azure cosmosdb access is a bit dated from last year ( |
Add support for Entra ID in the auto config for Azure Cosmos DB vector store support.
This PR also adds a few fixes/enhancements and corresponding tests:
/id
)