Skip to content

AMQP-830 Enable Hostname Verification by default #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

AMQP-830 Enable Hostname Verification by default #799

wants to merge 1 commit into from

Conversation

garyrussell
Copy link
Contributor

JIRA: https://jira.spring.io/browse/AMQP-830

Tested with a stand-alone boot app.

@artembilan
Copy link
Member

Here we have slightly different error:

org.springframework.amqp.rabbit.core.RabbitTemplateDirectReplyToContainerIntegrationPubCFTests > testReceiveAndReplyBlocking FAILED
    org.springframework.amqp.AmqpConnectException
        Caused by: com.rabbitmq.client.ShutdownSignalException

But it is still related to channel shutdown...

artembilan
artembilan reviewed Aug 28, 2018
View reviewed changes
src/reference/asciidoc/whats-new.adoc
===== Connection Factory Bean Changes

The `RabbitConnectionFactoryBean` now provides an `enabaleHostnameVerification` property; set it to `true` to enable host name verification.
Also `setHostnameVerifier` is provided for when using Java 6; see the connection factory javadocs for more information.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no such a functionality in this version.
Also the commit message is misleading.

Will fix on merge...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops - yes; thanks.

@artembilan
Copy link
Member

Merged as d64e7fa

@artembilan artembilan closed this Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artembilan artembilan artembilan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garyrussell @artembilan