Skip to content

Provide JDBC implementation of OAuth2AuthorizationConsentService #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jgrandja opened this issue Jun 16, 2021 · 13 comments · Fixed by #314
Closed

Provide JDBC implementation of OAuth2AuthorizationConsentService #313

jgrandja opened this issue Jun 16, 2021 · 13 comments · Fixed by #314
Labels
type: enhancement A general enhancement
Milestone
0.1.2

Comments

@jgrandja
Copy link
Collaborator

We need to provide a JDBC implementation of OAuth2AuthorizationConsentService that may be used for production deployments.

Related gh-283 gh-304
@jgrandja jgrandja added the type: enhancement A general enhancement label Jun 16, 2021
@jgrandja jgrandja added this to the 0.1.2 milestone Jun 16, 2021
@jgrandja jgrandja mentioned this issue Jun 16, 2021
Merged
@ghost
Copy link

ghost commented Jun 16, 2021

Hi @jgrandja . I can work on this one.

@jgrandja jgrandja assigned ghost Jun 16, 2021
@jgrandja
Copy link
Collaborator Author

Thanks for all your help @ovidiupopa91 !

sjohnr pushed a commit that referenced this issue Jun 16, 2021
Polish gh-313
7f095e0
sjohnr pushed a commit that referenced this issue Jun 16, 2021
Revert "Polish gh-313"
566064b 
This reverts commit 7f095e0
ghost pushed a commit to ovidiupopa07/spring-authorization-server that referenced this issue Jun 17, 2021
@ovidiupopa07
Provide JDBC implementation of OAuth2AuthorizationConsentService
52b9b93 
Add new JDBC implementation of the OAuth2AuthorizationConsentService
Add equals and hashCode methods in OAuth2AuthorizationConsent

Closes spring-projectsgh-313
ghost pushed a commit to ovidiupopa07/spring-authorization-server that referenced this issue Jun 17, 2021
@ovidiupopa07
Provide JDBC implementation of OAuth2AuthorizationConsentService
606dd73 
Add new JDBC implementation of the OAuth2AuthorizationConsentService
Add equals and hashCode methods in OAuth2AuthorizationConsent

Closes spring-projectsgh-313
@ghost ghost mentioned this issue Jun 17, 2021
Merged
ghost pushed a commit to ovidiupopa07/spring-authorization-server that referenced this issue Jun 17, 2021
@ovidiupopa07
Provide JDBC implementation of OAuth2AuthorizationConsentService
0e3f000 
Add new JDBC implementation of the OAuth2AuthorizationConsentService
Add equals and hashCode methods in OAuth2AuthorizationConsent

Closes spring-projectsgh-313
sjohnr pushed a commit that referenced this issue Jun 18, 2021
@ovidiupopa07 @sjohnr
Provide JDBC implementation of OAuth2AuthorizationConsentService
5dbe973 
Add new JDBC implementation of the OAuth2AuthorizationConsentService
Add equals and hashCode methods in OAuth2AuthorizationConsent

Closes gh-313
@sjohnr sjohnr mentioned this issue Jun 18, 2021
Closed
@ghost
Copy link

ghost commented Jun 23, 2021

hi @jgrandja . Let me know when you have something planned for the 0.2.0 release. Unfortunately for the 0.1.2 release I won't be able to help anymore as I will be off next week.

@jgrandja
Copy link
Collaborator Author

@ovidiupopa91 Please ping me when you return from your time off. Enjoy!

@ghost
Copy link

ghost commented Jul 5, 2021

Hi @jgrandja . I'm back from my PTO. Let me know when you have something that I can take a look at.

@jgrandja
Copy link
Collaborator Author

jgrandja commented Jul 7, 2021

Hi @ovidiupopa91 . Let me get back to you this Friday after I release 0.1.2. Hope you enjoyed your time off :)

@ghost
Copy link

ghost commented Jul 8, 2021

Hi @jgrandja, sure. Yes, it was a great. A well deserved break :)

@jgrandja
Copy link
Collaborator Author

jgrandja commented Jul 9, 2021

Hi @ovidiupopa91, I'm on PTO all of next week. I'll plan 0.2.0 tasks when I return and will follow up with you then. Thanks.

@ghost
Copy link

ghost commented Jul 9, 2021

Enjoy your time off @jgrandja !

@jgrandja
Copy link
Collaborator Author

Hi @ovidiupopa91. The plan for 0.2.0 is mostly polish and technical debt tasks as we are preparing the release to be production-ready. New features are on hold until after 0.2.0 is out.

One task on the list is adding update support in JdbcRegisteredClientRepository.save(). It currently only supports insert. Would this be of interest?

We also need to implement the Client Configuration Endpoint which could go into 0.2.1. Let me know if you're interested in this one as well.

@ghost
Copy link

ghost commented Jul 21, 2021

Hi @jgrandja, welcome back. I am ok with both of them 👍

@jgrandja
Copy link
Collaborator Author

Great @ovidiupopa91. Can you log the issues and then I can assign to you.

@ghost
Copy link

ghost commented Jul 21, 2021

@jgrandja issues opened: gh-355 and gh-356

doba16 pushed a commit to doba16/spring-authorization-server that referenced this issue Apr 21, 2023
Polish spring-projectsgh-313
99d86d9
doba16 pushed a commit to doba16/spring-authorization-server that referenced this issue Apr 21, 2023
Revert "Polish spring-projectsgh-313"
91e3786 
This reverts commit 99d86d9
doba16 pushed a commit to doba16/spring-authorization-server that referenced this issue Apr 21, 2023
@ovidiupopa07 @sjohnr
Provide JDBC implementation of OAuth2AuthorizationConsentService
393f310 
Add new JDBC implementation of the OAuth2AuthorizationConsentService
Add equals and hashCode methods in OAuth2AuthorizationConsent

Closes spring-projectsgh-313
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
0.1.2
1 participant
@jgrandja