Skip to content

Support JWT Bearer Client Authentication #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jgrandja opened this issue Apr 21, 2020 · 5 comments
Closed

Support JWT Bearer Client Authentication #59

jgrandja opened this issue Apr 21, 2020 · 5 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@jgrandja
Copy link
Collaborator

jgrandja commented Apr 21, 2020

This feature will deliver Using JWTs for Client Authentication defined in the JSON Web Token (JWT) Profile spec.

@jgrandja jgrandja changed the title JSON Web Token (JWT) Profile Epic: JSON Web Token (JWT) Profile Apr 21, 2020
@jgrandja jgrandja added the status: on-hold We can't start working on this issue yet label Apr 23, 2020
@jgrandja jgrandja added this to the 0.1.2 milestone Jan 29, 2021
@rlewczuk
Copy link
Contributor

rlewczuk commented Mar 29, 2021

I've implemented client authentication part of this specification. If there are no objections, I'm ready to issue PR as soon as 0.1.2 cycle starts.

This implementation contains significant amount of duplicated code (PKCE related) that needs to be factored out, I'm aware of that and plan to take care of it.

Branch implementing this feature is here: https://github.com/rlewczuk/spring-authorization-server/tree/jwt-client-auth

Update: JWT client authentication is also being implemented in spring-security, so this patch needs to rebased to new spring-security and adapted to new codebase

@rlewczuk
Copy link
Contributor

rlewczuk commented Apr 2, 2021

Here is another part of this epic - JWT assertion grant type: https://github.com/rlewczuk/spring-authorization-server/tree/jwt-assertion-grant

In both parts I had to make some design decisions that really need to be reviewed and discussed. Plus I have to review it once again for compliance with RFC (especially error codes). If you have time some time next week, we can start working on this.

Update: JWT authentication grants is also being implemented in spring-security, so this patch needs to rebased to new spring-security and adapted to new codebase

@jgrandja
Copy link
Collaborator Author

jgrandja commented Apr 5, 2021

Thanks @rlewczuk !

Let's focus on JWT client authentication for 0.1.2. I'm not sure when JWT authorization grant will get scheduled at this point.

I'm pretty backlogged over the next 2 weeks. After 0.1.1 is out, please submit PR for JWT client authentication. Thanks!

@jgrandja jgrandja changed the title Epic: JSON Web Token (JWT) Profile Support JWT Bearer Client Authentication May 20, 2021
@jgrandja jgrandja added type: enhancement A general enhancement and removed status: on-hold We can't start working on this issue yet labels May 20, 2021
@jgrandja jgrandja modified the milestones: 0.1.2, 0.2.0 Jun 17, 2021
@jgrandja jgrandja modified the milestones: 0.2.0, 0.2.1 Jul 21, 2021
@larsw
Copy link

larsw commented Sep 6, 2021

What's the status for this feature?

@jgrandja
Copy link
Collaborator Author

@larsw This is scheduled for 0.2.1 as indicated in the Milestone.

rlewczuk added a commit to rlewczuk/spring-authorization-server that referenced this issue Nov 11, 2021
rlewczuk added a commit to rlewczuk/spring-authorization-server that referenced this issue Nov 12, 2021
rlewczuk added a commit to rlewczuk/spring-authorization-server that referenced this issue Nov 14, 2021
rlewczuk added a commit to rlewczuk/spring-authorization-server that referenced this issue Nov 14, 2021
rlewczuk added a commit to rlewczuk/spring-authorization-server that referenced this issue Nov 15, 2021
rlewczuk added a commit to rlewczuk/spring-authorization-server that referenced this issue Nov 17, 2021
rlewczuk added a commit to rlewczuk/spring-authorization-server that referenced this issue Nov 18, 2021
rlewczuk added a commit to rlewczuk/spring-authorization-server that referenced this issue Nov 19, 2021
rlewczuk added a commit to rlewczuk/spring-authorization-server that referenced this issue Nov 20, 2021
rlewczuk added a commit to rlewczuk/spring-authorization-server that referenced this issue Nov 20, 2021
rlewczuk added a commit to rlewczuk/spring-authorization-server that referenced this issue Nov 21, 2021
rlewczuk added a commit to rlewczuk/spring-authorization-server that referenced this issue Nov 22, 2021
@jgrandja jgrandja modified the milestones: 0.2.1, 0.2.2 Nov 26, 2021
rlewczuk added a commit to rlewczuk/spring-authorization-server that referenced this issue Dec 5, 2021
rlewczuk added a commit to rlewczuk/spring-authorization-server that referenced this issue Dec 8, 2021
rlewczuk added a commit to rlewczuk/spring-authorization-server that referenced this issue Dec 8, 2021
rlewczuk added a commit to rlewczuk/spring-authorization-server that referenced this issue Dec 16, 2021
doba16 pushed a commit to doba16/spring-authorization-server that referenced this issue Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants