Skip to content

Allow configurable scope validation strategy in OAuth2ClientCredentialsAuthenticationProvider #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Allow configurable scope validation strategy in OAuth2ClientCredentialsAuthenticationProvider #1377

wants to merge 1 commit into from

Conversation

adamleantech
Copy link
Contributor

@adamleantech adamleantech commented Oct 2, 2023 •
edited
Loading

resolves #884

@adamleantech adamleantech marked this pull request as draft October 2, 2023 09:18
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 2, 2023
@jgrandja jgrandja added status: waiting-for-feedback We need additional information before we can continue and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 11, 2023
@jgrandja jgrandja changed the title Initial draft Allow configurable scope validation strategy in OAuth2ClientCredentialsAuthenticationProvider Oct 11, 2023
@jgrandja jgrandja added type: enhancement A general enhancement and removed status: waiting-for-feedback We need additional information before we can continue labels Oct 19, 2023
@jgrandja jgrandja added this to the 1.3.x milestone Oct 20, 2023
@jgrandja jgrandja modified the milestones: 1.3.x, 1.3.0-M1 Nov 21, 2023
@adamleantech adamleantech force-pushed the add-configurable-client_credentials-scope-validation branch from b9616cd to 412a93a Compare January 2, 2024 12:03
@adamleantech adamleantech marked this pull request as ready for review January 2, 2024 12:48
@jgrandja
Copy link
Collaborator

jgrandja commented Jan 9, 2024

Thanks for the updates @adamleantech ! Can you please squash to 1 commit.

I'll aim to merge this before the release next Tuesday.

@adamleantech adamleantech force-pushed the add-configurable-client_credentials-scope-validation branch from 773c7a5 to 80036b9 Compare January 10, 2024 09:25
@jgrandja jgrandja self-assigned this Jan 10, 2024
@jgrandja jgrandja closed this in 5c3f1cb Jan 15, 2024
jgrandja added a commit that referenced this pull request Jan 15, 2024
@jgrandja
Polish gh-1377
9757e33
@jgrandja
Copy link
Collaborator

@adamleantech This is now merged. FYI, I added a polish commit as a few changes were needed. Please let me know if you have any questions in regards to the updates. Thanks!

@jgrandja jgrandja mentioned this pull request Jan 15, 2024
Closed
jgrandja added a commit that referenced this pull request Jan 16, 2024
@jgrandja
Document usage for OAuth2ClientCredentialsAuthenticationProvider.setA…
1d0e6cb 
…uthenticationValidator()

Issue gh-1377
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgrandja jgrandja jgrandja left review comments

Assignees

@jgrandja jgrandja

Labels
type: enhancement A general enhancement
Projects
Spring Security Team
Status: Done
Milestone
1.3.0-M1
Development

Successfully merging this pull request may close these issues.

Consider a lenient scope validation strategy in OAuth2ClientCredentialsAuthenticationProvider
3 participants
@adamleantech @jgrandja @spring-projects-issues