Support custom validation in OidcLogoutAuthenticationProvider #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jgrandja
added
type: enhancement
jgrandja
requested changes
Sep 26, 2024
There was a problem hiding this comment.
Thanks for the PR @Kehrlann !
In addition to addressing the feedback, please add documentation to the reference similar to Customizing Authorization Request Validation and Customizing Client Credentials Grant Request Validation.
...ecurity/oauth2/server/authorization/oidc/authentication/OidcLogoutAuthenticationContext.java
Outdated
Show resolved
Hide resolved
...curity/oauth2/server/authorization/oidc/authentication/OidcLogoutAuthenticationProvider.java
Show resolved
Hide resolved
...urity/oauth2/server/authorization/oidc/authentication/OidcLogoutAuthenticationValidator.java
Outdated
Show resolved
Hide resolved
...ecurity/oauth2/server/authorization/oidc/authentication/OidcLogoutAuthenticationContext.java
Outdated
Show resolved
Hide resolved
...urity/oauth2/server/authorization/oidc/authentication/OidcLogoutAuthenticationValidator.java
Outdated
Show resolved
Hide resolved
Kehrlann
force-pushed
the
customize-post-logout-redirect-uri-check
branch
2 times, most recently
from
ef54d36 to
6ead3f5
Compare
Kehrlann
force-pushed
the
customize-post-logout-redirect-uri-check
branch
from
6ead3f5 to
1e2bfe9
Compare
- Similar to custom validation in OAuth2AuthorizationCodeRequestAuthenticationProvider - Closes spring-projectsgh-1693
Kehrlann
force-pushed
the
customize-post-logout-redirect-uri-check
branch
from
1e2bfe9 to
50959c7
Compare
|
Thanks for the updates @Kehrlann ! This is now merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OAuth2AuthorizationCodeRequestAuthenticationProviderpost_logout_redirect_urivalidation in OIDC RP-initiated logout #1693