AOT contributions will be registered for JbcOAuth2AuthorizationService subclasses #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jgrandja
requested changes
Oct 18, 2024
| @@ -43,8 +43,10 @@ | |||
| import org.springframework.security.oauth2.core.oidc.user.OidcUserAuthority; | |||
| import org.springframework.security.oauth2.core.user.DefaultOAuth2User; | |||
| @@ -0,0 +1,108 @@ | |||
| /* | |||
| * Copyright 2020-2021 the original author or authors. | |||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| class OAuth2AuthorizationServerBeanRegistrationAotProcessorTests { |
There was a problem hiding this comment.
Add javadoc similar to other tests
|
|
||
| class OAuth2AuthorizationServerBeanRegistrationAotProcessorTests { | ||
|
|
||
| OAuth2AuthorizationServerBeanRegistrationAotProcessor processor; |
There was a problem hiding this comment.
Make the members private
| @ParameterizedTest | ||
| @ValueSource(classes = { JdbcOAuth2AuthorizationService.class, CustomJdbcOAuth2AuthorizationService.class, | ||
| JdbcRegisteredClientRepository.class, CustomJdbcRegisteredClientRepository.class }) | ||
| void whenABeanRegistrationAotContributionShouldBeReturned(Class<?> beanClass) { |
There was a problem hiding this comment.
Rename to processAheadOfTimeWhenBeanTypeJdbcBasedImplThenReturnContribution
| @ParameterizedTest | ||
| @ValueSource(classes = { InMemoryOAuth2AuthorizationService.class, InMemoryRegisteredClientRepository.class, | ||
| Object.class }) | ||
| void whenABeanRegistrationAotContributionShouldNotBeReturned(Class<?> beanClass) { |
There was a problem hiding this comment.
Rename to processAheadOfTimeWhenBeanTypeNotJdbcBasedImplThenDoesNotReturnContribution
| } | ||
|
|
||
| @Test | ||
| void aotContributionOnlyNeedsSpecifiedOnce() { |
There was a problem hiding this comment.
Rename to processAheadOfTimeWhenMultipleBeanTypeJdbcBasedImplThenReturnContributionOnce
jgrandja
added
type: bug
…e subclasses Prior to this commit, String-based class name comparisons were used for determining if a bean was of type JdbcOAuth2AuthorizationService or JdbcRegisteredClientRepository. Now JdbcOAuth2AuthorizationService.class.isAssignableFrom(...) and JdbcRegisteredClientRepository.class.isAssignableFrom(...) is used so that any subclasses are detected and the necessary AOT hints are contributed. closes spring-projectsgh-1737
|
@jgrandja Thanks for the review! I believe I've addressed all the comments. Please let me know if there's anything else you'd like me to change. |
|
Thanks for the updates @billkoch. This is now merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AOT contributions will be registered for JbcOAuth2AuthorizationService subclasses
Prior to this commit, String-based class name comparisons were used for determining if a bean was of type JdbcOAuth2AuthorizationService or JdbcRegisteredClientRepository.
Now JdbcOAuth2AuthorizationService.class.isAssignableFrom(...) and JdbcRegisteredClientRepository.class.isAssignableFrom(...) is used so that any subclasses are detected and the necessary AOT hints are contributed.
closes gh-1737