Use empty map for missing additional parameters #1826
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
TheMrMilchmann
force-pushed
the
tmm/fix/additional-params
branch
from
f558441 to
144fe72
Compare
jgrandja
added
type: enhancement
jgrandja
requested changes
Nov 21, 2024
There was a problem hiding this comment.
Thanks for the PR @TheMrMilchmann.
Please see review comment and then we can get this merged.
...server/authorization/authentication/OAuth2DeviceAuthorizationRequestAuthenticationToken.java
Outdated
Show resolved
Hide resolved
.../oauth2/server/authorization/authentication/OAuth2DeviceVerificationAuthenticationToken.java
Outdated
Show resolved
Hide resolved
This is not only more consistent with the other tokens which use an empty map, but also more in line with the documentation (at least for `OAuth2DeviceVerificationAuthenticationToken`).
TheMrMilchmann
force-pushed
the
tmm/fix/additional-params
branch
from
144fe72 to
c536f1b
Compare
jgrandja
changed the title
|
Thanks for the updates @TheMrMilchmann. This is now merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not only more consistent with the other tokens which use an empty map, but also more in line with the documentation (at least for
OAuth2DeviceVerificationAuthenticationToken).