Fix device access token response error codes #1889
Closed
+48
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
Signed-off-by: Nick Holloway <[email protected]>
jgrandja
added
type: bug
|
@nwholloway Thank you. I will get to this next week. I'm trying to wrap up a priority task by end of this week. |
jgrandja
changed the title
|
Thanks for the PR @nwholloway. This is now merged. FYI, I added a polish commit. Please let me know if you have any questions for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two occurrences of the Device Access Token Response returning "authorization_pending" and not the expected response.
The first is when the device token has expired (as raised in #1885). This now returns the error "expired_token".
The second is when the device token has been invalidated, but the user token has not been invalidated. This state occurs when a request has been made with the incorrect client, or after device token expiry. This now returns the error "invalid_grant".