Skip to content

Fix authorization code expired check #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix authorization code expired check #299

wants to merge 2 commits into from

Conversation

sjohnr
Copy link
Contributor

@sjohnr sjohnr commented May 20, 2021

Closes gh-290

@sjohnr sjohnr requested a review from jgrandja May 20, 2021 19:38
@sjohnr sjohnr marked this pull request as draft May 20, 2021 19:40
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 20, 2021
@sjohnr sjohnr marked this pull request as ready for review May 20, 2021 19:44
@sjohnr sjohnr added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels May 24, 2021
@jgrandja jgrandja added this to the 0.1.2 milestone May 25, 2021
jgrandja
jgrandja requested changes May 25, 2021
View reviewed changes
Copy link
Collaborator

@jgrandja jgrandja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @sjohnr. Please see review comments.

@sjohnr sjohnr requested a review from jgrandja May 25, 2021 16:06
@jgrandja jgrandja changed the title Fix token expired and not before use check Fix token expired check May 26, 2021
@jgrandja jgrandja changed the title Fix token expired check Fix authorization code expired check May 26, 2021
@jgrandja jgrandja added the status: duplicate A duplicate of another issue label May 26, 2021
@jgrandja jgrandja closed this May 26, 2021
@jgrandja jgrandja deleted the gh-290 branch May 26, 2021 17:51
@jgrandja
Copy link
Collaborator

Thanks for the PR @sjohnr. This is now in main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgrandja jgrandja Awaiting requested review from jgrandja

Assignees

@jgrandja jgrandja

Labels
status: duplicate A duplicate of another issue type: bug A general bug
Projects
None yet
Milestone
0.1.2
Development

Successfully merging this pull request may close these issues.

OAuth2AuthorizationCodeAuthenticationProvider should check if the code has expired
3 participants
@sjohnr @jgrandja @spring-projects-issues