Skip to content

Implement User Info Endpoint #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Implement User Info Endpoint #441

wants to merge 2 commits into from

Conversation

sjohnr
Copy link
Contributor

@sjohnr sjohnr commented Sep 17, 2021

Closes gh-176

@sjohnr sjohnr added status: duplicate A duplicate of another issue type: enhancement A general enhancement labels Sep 17, 2021
@sjohnr sjohnr added this to the 0.2.1 milestone Sep 17, 2021
@sjohnr sjohnr requested a review from jgrandja September 17, 2021 17:07
@sjohnr sjohnr mentioned this pull request Sep 17, 2021
Closed
@sjohnr sjohnr force-pushed the gh-176 branch 2 times, most recently from 0603588 to 970ce39 Compare September 21, 2021 14:11
idosal
idosal reviewed Sep 21, 2021
View reviewed changes
Copy link
Contributor

@idosal idosal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! The suggestions from my PR fit really well. Added a few minor comments for your consideration. Let me know if there's anything else I can help with.

@sjohnr sjohnr marked this pull request as ready for review September 21, 2021 19:52
@sjohnr
Copy link
Contributor Author

sjohnr commented Sep 21, 2021

@idosal Thanks! I've incorporated your original commits into this PR, as well as minor changes based on your feedback. (I'll squash the last commit before merging.)

@Insutanto
Copy link

Hi, When will this feature be released? I am waiting for it.

jgrandja
jgrandja requested changes Oct 6, 2021
View reviewed changes
Copy link
Collaborator

@jgrandja jgrandja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @sjohnr. Please see review comments.

@sjohnr sjohnr requested a review from jgrandja October 8, 2021 19:34
jgrandja
jgrandja requested changes Oct 14, 2021
View reviewed changes
Copy link
Collaborator

@jgrandja jgrandja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @sjohnr. Please see review comments.

@sjohnr
Copy link
Contributor Author

sjohnr commented Oct 19, 2021

@jgrandja I finished preliminary changes based on your feedback. I still need to solve the issued_at JSON number, and then I'll squash etc. But everything else has been worked on.

@sjohnr
Copy link
Contributor Author

sjohnr commented Oct 20, 2021

@jgrandja this is ready for final review. Thanks for the feedback!

@sjohnr sjohnr requested a review from jgrandja October 20, 2021 21:23
@yangyaofei
Copy link

I got a 401 when I use this.

The OAuth2 Client call userinfo only with jwt token, and because UserInfo filter behind the FilterSecurityInterceptor
the result always 401.

Is there anything I use wrong? I just use the default settings.

@sjohnr
Copy link
Contributor Author

sjohnr commented Oct 25, 2021

@yangyaofei See this integration test for an example of how to configure authorization server for user info.

@yangyaofei
Copy link

@sjohnr oh, thank you, when I add http.oauth2ResourceServer().jwt(); and jwtDecoder Bean to configure, it works great.

I'm looking forward to see this PR merged and release in 0.2.1, and then I can ues this in my productions, thank you again.

jgrandja added a commit that referenced this pull request Oct 25, 2021
@jgrandja
Polish gh-441
72c5e24
@jgrandja
Copy link
Collaborator

jgrandja commented Oct 25, 2021 •
edited
Loading

Thanks for the updates @sjohnr. This is now in main!
FYI, I added a polish commit with some very minor updates.

@jgrandja jgrandja closed this Oct 25, 2021
@sjohnr sjohnr deleted the gh-176 branch October 25, 2021 17:02
jgrandja added a commit that referenced this pull request Nov 30, 2021
@jgrandja
Introduce OidcUserInfoAuthenticationContext
82e4f3a 
Issue gh-441
doba16 pushed a commit to doba16/spring-authorization-server that referenced this pull request Apr 21, 2023
@jgrandja
Polish spring-projectsgh-441
a77a0ea
doba16 pushed a commit to doba16/spring-authorization-server that referenced this pull request Apr 21, 2023
@jgrandja
Introduce OidcUserInfoAuthenticationContext
0c34538 
Issue spring-projectsgh-441
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idosal idosal idosal left review comments

@jgrandja jgrandja Awaiting requested review from jgrandja

Assignees

@jgrandja jgrandja

Labels
status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
0.2.1
Development

Successfully merging this pull request may close these issues.

Implement UserInfo Endpoint
5 participants
@sjohnr @Insutanto @yangyaofei @jgrandja @idosal