Skip to content

Improve customizing OIDC UserInfo endpoint #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Improve customizing OIDC UserInfo endpoint #929

wants to merge 1 commit into from

Conversation

Kehrlann
Copy link
Contributor

@Kehrlann Kehrlann commented Oct 21, 2022 •
edited
Loading

Closes gh-785

@Kehrlann
Copy link
Contributor Author

Kehrlann commented Oct 21, 2022 •
edited
Loading

Note: I added a missing test in OidcUserInfoEndpointFilterTests while I was editing it, unrelated to the current change (doFilterWhenUserInfoRequestInsufficientScopeThenForbiddenError)

@Kehrlann Kehrlann force-pushed the improve-customizing-oidc-userinfo-endpoint branch from 93ed40c to 6c7b011 Compare October 21, 2022 09:40
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 21, 2022
@Kehrlann Kehrlann force-pushed the improve-customizing-oidc-userinfo-endpoint branch 2 times, most recently from 5698b03 to 129ff3e Compare October 21, 2022 09:45
@Kehrlann Kehrlann changed the base branch from main to 0.4.x October 21, 2022 09:46
@Kehrlann Kehrlann force-pushed the improve-customizing-oidc-userinfo-endpoint branch 3 times, most recently from af3e0ec to e617236 Compare October 24, 2022 08:09
@jgrandja jgrandja self-assigned this Oct 24, 2022
@jgrandja jgrandja added status: duplicate A duplicate of another issue type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 24, 2022
@jgrandja jgrandja added this to the 0.4.0-RC1 milestone Oct 24, 2022
jgrandja
jgrandja requested changes Oct 24, 2022
View reviewed changes
Copy link
Collaborator

@jgrandja jgrandja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Kehrlann.

Please see review comments. Also, please document in the reference manual (protocol-endpoints.adoc) the new configuration methods.

Thanks.

@Kehrlann Kehrlann force-pushed the improve-customizing-oidc-userinfo-endpoint branch 3 times, most recently from f1f60c0 to c97ecaa Compare October 26, 2022 23:14
@Kehrlann Kehrlann requested a review from jgrandja October 26, 2022 23:24
@Kehrlann Kehrlann force-pushed the improve-customizing-oidc-userinfo-endpoint branch from c97ecaa to e7dd6de Compare October 27, 2022 15:11
jgrandja added a commit that referenced this pull request Oct 28, 2022
@jgrandja
Polish gh-929
2ba711c
@jgrandja
Copy link
Collaborator

Thanks for the updates @Kehrlann. This is now merged.

@jgrandja jgrandja closed this Oct 28, 2022
jgrandja added a commit that referenced this pull request Oct 28, 2022
@jgrandja
Polish gh-929
11ce8ef
jgrandja added a commit that referenced this pull request Oct 31, 2022
@jgrandja
Merge branch 0.4.x into main
4adc376 
The following commits are merged using the default merge strategy.

8d7f8b3 Improve customizing OIDC UserInfo endpoint
2ba711c Polish gh-929
efbfdc2 Improve customizing OIDC Client Registration endpoint
bfd7a09 Polish gh-946
11ce8ef Polish gh-929
356d669 Fix URL encoding for authorization request state parameter
4eb25c1 Polish gh-920
6dc3944 Add OidcClientRegistrationAuthenticationProvider.setRegisteredClientConverter()
doba16 pushed a commit to doba16/spring-authorization-server that referenced this pull request Apr 21, 2023
@jgrandja
Polish spring-projectsgh-929
286ecad
doba16 pushed a commit to doba16/spring-authorization-server that referenced this pull request Apr 21, 2023
@jgrandja
Polish spring-projectsgh-929
92669d0
doba16 pushed a commit to doba16/spring-authorization-server that referenced this pull request Apr 21, 2023
@jgrandja
Merge branch 0.4.x into main
82efcdd 
The following commits are merged using the default merge strategy.

d669a6b Improve customizing OIDC UserInfo endpoint
286ecad Polish spring-projectsgh-929
ad58264 Improve customizing OIDC Client Registration endpoint
bb91d54 Polish spring-projectsgh-946
92669d0 Polish spring-projectsgh-929
18236f5 Fix URL encoding for authorization request state parameter
cdcc5ad Polish spring-projectsgh-920
d148d8d Add OidcClientRegistrationAuthenticationProvider.setRegisteredClientConverter()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgrandja jgrandja Awaiting requested review from jgrandja

Assignees

@jgrandja jgrandja

Labels
status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
0.4.0-RC1
Development

Successfully merging this pull request may close these issues.

Improve customizing OIDC UserInfo endpoint
3 participants
@Kehrlann @jgrandja @spring-projects-issues