Skip to content

Implement equals and hashCode in Chunk class #4296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jpraet opened this issue Feb 11, 2023 · 1 comment
Closed

Implement equals and hashCode in Chunk class #4296

jpraet opened this issue Feb 11, 2023 · 1 comment
Labels
in: core type: enhancement
Milestone
5.0.1

Comments

@jpraet
Copy link
Contributor

jpraet commented Feb 11, 2023

The Chunk class does not currently implement equals and hashCode.

This small enhancement would, among other things, facilitate testing custom ItemWriter implementations with mockito.
@jpraet jpraet added the status: waiting-for-triage Issues that we did not analyse yet label Feb 11, 2023
@fmbenhassine fmbenhassine added in: core type: enhancement and removed status: waiting-for-triage Issues that we did not analyse yet labels Feb 13, 2023
@fmbenhassine fmbenhassine added this to the 5.0.1 milestone Feb 13, 2023
@baezzys baezzys mentioned this issue Feb 14, 2023
Closed
@fmbenhassine fmbenhassine linked a pull request Feb 15, 2023 that will close this issue
Add equals() and hashcode() overrides to chunk class #4300
Closed
@jpraet
Copy link
Contributor Author

jpraet commented Feb 23, 2023

There is a problem: the PR #4300 adds equals and hashCode to the ChunkIterator class instead of to the Chunk class.

@jpraet jpraet mentioned this issue Feb 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: core type: enhancement
Projects
None yet
Milestone
5.0.1
Development

Successfully merging a pull request may close this issue.

Add equals() and hashcode() overrides to chunk class baezzys/spring-batch
2 participants
@fmbenhassine @jpraet