Skip to content

Implement equals and hashCode in Chunk class #4314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jpraet opened this issue Feb 25, 2023 · 3 comments
Closed

Implement equals and hashCode in Chunk class #4314

jpraet opened this issue Feb 25, 2023 · 3 comments
Labels
in: infrastructure type: bug
Milestone
5.0.2

Comments

@jpraet
Copy link
Contributor

jpraet commented Feb 25, 2023

See #4296. There is a problem with the PR #4300 that made it into 5.0.1:
it adds equals and hashCode to the ChunkIterator class instead of to the Chunk class.
@jpraet jpraet added status: waiting-for-triage Issues that we did not analyse yet type: bug labels Feb 25, 2023
@fmbenhassine
Copy link
Contributor

Thank you for raising this! The PR was off-by-one brace and I missed that when reviewing it. My bad 🤦..

I will fix this in 5.0.2.

@fmbenhassine fmbenhassine added in: infrastructure and removed status: waiting-for-triage Issues that we did not analyse yet labels Feb 27, 2023
@fmbenhassine fmbenhassine added this to the 5.0.2 milestone Feb 27, 2023
@baezzys
Copy link
Contributor

baezzys commented Feb 28, 2023 •
edited
Loading

Sorry for my mistake.. I'll fix it.

@baezzys baezzys mentioned this issue Feb 28, 2023
Closed
@fmbenhassine fmbenhassine linked a pull request Mar 21, 2023 that will close this issue
Fix incorrectly added functions. #4317
Closed
@fmbenhassine fmbenhassine mentioned this issue May 11, 2023
Open
fmbenhassine pushed a commit that referenced this issue May 11, 2023
@baezzys @fmbenhassine
Move equals/hashcode from ChunkIterator to Chunk class
30e8766 
Those methods were mistakenly added in ChunkIterator.

Issue #4314
@fmbenhassine
Copy link
Contributor

This was resolved with #4317, but has exposed a seemingly old hidden bug as explained here: #4317 (comment).

I created #4370 for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: infrastructure type: bug
Projects
None yet
Milestone
5.0.2
Development

Successfully merging a pull request may close this issue.

Fix incorrectly added functions. baezzys/spring-batch
3 participants
@fmbenhassine @jpraet @baezzys