Skip to content

Enhance switch statements #4365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Enhance switch statements #4365

wants to merge 1 commit into from

Conversation

viviennes7
Copy link
Contributor

Hello !
I Replaced with enhanced switch statement
Thank you.

@fmbenhassine
Copy link
Contributor

That's great! Thank you for your PR 👍

Could you please update the year in license headers where appropriate and use your real name in git commits? Please check the contributor guide.

Other than that, it should be good to merge. Thank you upfront.

@fmbenhassine fmbenhassine added pr-for: enhancement status: waiting-for-reporter Issues for which we are waiting for feedback from the reporter in: core labels May 3, 2023
@fmbenhassine fmbenhassine added this to the 5.0.2 milestone May 3, 2023
@viviennes7
Copy link
Contributor Author

@fmbenhassine
fix copyright year and commit author
Thank you👍

@fmbenhassine fmbenhassine added status: feedback-provided Issues for which the feedback requested from the reporter was provided and removed status: waiting-for-reporter Issues for which we are waiting for feedback from the reporter labels May 3, 2023
@fmbenhassine fmbenhassine changed the title Replace with enhanced switch statement Enhanced switch statements May 3, 2023
@fmbenhassine fmbenhassine changed the title Enhanced switch statements Enhance switch statements May 3, 2023
fmbenhassine pushed a commit that referenced this pull request May 3, 2023
@fmbenhassine
Copy link
Contributor

Thank you for the updates! LGTM now 👍

Rebased and merged as 4a971a0. Thank you for your contribution!

@fmbenhassine fmbenhassine removed the status: feedback-provided Issues for which the feedback requested from the reporter was provided label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants