Skip to content

Make the runScripts method on AbstractScriptDatabaseInitializer more extensible #29137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
snicoll opened this issue Dec 20, 2021 · 1 comment
Closed

Make the runScripts method on AbstractScriptDatabaseInitializer more extensible #29137

snicoll opened this issue Dec 20, 2021 · 1 comment
Assignees
@wilkinsona
Labels
type: enhancement A general enhancement
Milestone
3.0.0-RC1

Comments

@snicoll
Copy link
Member

snicoll commented Dec 20, 2021 •
edited
Loading

As revealed by fixing #29095, the configuration of the settings are done by a protected method that takes individual arguments. Adding an extra setting (for instance, comment prefixes) would break the method in its current form.

We should revisit this arrangement so that perhaps the settings (or at least something inherited from it) is used to configure the populator.
@snicoll snicoll added the type: enhancement A general enhancement label Dec 20, 2021
@snicoll snicoll added this to the 2.7.x milestone Dec 20, 2021
terminux added a commit to terminux/spring-boot that referenced this issue Dec 24, 2021
@terminux
QuartzDataSourceScriptDatabaseInitializer support more extra settings
2761a71 
Closes spring-projectsgh-29137
@terminux terminux mentioned this issue Dec 24, 2021
Closed
@terminux
Copy link
Contributor

terminux commented Dec 24, 2021 •
edited
Loading

Hi, maybe we can replace a single parameter with the corresponding Properties(such as QuartzProperties), I submitted a PR. #29162

@wilkinsona wilkinsona modified the milestones: 2.7.x, 3.0.x Apr 11, 2022
@wilkinsona wilkinsona self-assigned this Oct 5, 2022
@wilkinsona wilkinsona changed the title Revisit ScriptDatabaseInitializer configuration Make the runScripts method on AbstractScriptDatabaseInitializer more extensible Oct 5, 2022
@wilkinsona wilkinsona modified the milestones: 3.0.x, 3.0.0-RC1 Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilkinsona wilkinsona

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.0.0-RC1
Development

Successfully merging a pull request may close this issue.

QuartzDataSourceScriptDatabaseInitializer support more extra settings terminux/spring-boot
3 participants
@snicoll @wilkinsona @terminux