Skip to content

Remove auto-configuration for Apache Solr until it is compatible with Jetty 11 #31054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wilkinsona opened this issue May 16, 2022 · 2 comments
Closed
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@wilkinsona
Copy link
Member

No description provided.

@wilkinsona wilkinsona added the type: dependency-upgrade A dependency upgrade label May 16, 2022
@wilkinsona wilkinsona added this to the 3.0.0-M3 milestone May 16, 2022
@wilkinsona
Copy link
Member Author

Solr 9's new Http2SolrClient requires Jetty 9.4. There's a PR to move to Jetty 10 but we require Jetty 11 for Jakarta EE 9 compatibility.

@wilkinsona wilkinsona reopened this May 16, 2022
wilkinsona added a commit that referenced this issue May 16, 2022
It requires Jetty 9.4.x but we're using Jetty 11.

This reverts commit b2bd3de.

See gh-31054
@wilkinsona
Copy link
Member Author

We auto-configure HttpSolrClient and Solr 9.0 has deprecated it in favor of Http2SolrClient. Http2SolrClient was introduced in Solr 8.x. Unlike HttpSolrClient, it depends on Jetty's HTTP client and, as noted above, it requires Jetty 9.4. That's fine in Spring Boot 2.x where we use Jetty 9.4.x by default but creates a problem in 3.0 where we require Jetty 11 (the same as Jetty 10 but with Jakarta EE 9 support).

If Solr moved to Jetty 10, I think we'd be OK as the HTTP client doesn't depend on any Servlet API, so it should also work with Jetty 11. If we stay on Solr 8, it'll work as long as we stick with HttpSolrClient and no one tries to use Http2SolrClient. If we upgrade to Solr 9, we can't use Http2SolrClient so we'd have to stick with the now-deprecated Http2SolrClient.

Given that we know that both Solr 8 and 9 won't work fully with 3.0 due to the Jetty 9 dependency, I think we may have to remove auto-configuration for Solr until it has brought its dependency up to date.

@wilkinsona wilkinsona changed the title Upgrade to Solr 9.0.0 Remove auto-configuration for Apache Solr until it is compatible with Jetty 11 May 16, 2022
@wilkinsona wilkinsona added type: enhancement A general enhancement and removed type: dependency-upgrade A dependency upgrade labels May 16, 2022
@wilkinsona wilkinsona modified the milestones: 3.0.0-M3, 3.0.x May 16, 2022
@wilkinsona wilkinsona self-assigned this May 18, 2022
@wilkinsona wilkinsona modified the milestones: 3.0.x, 3.0.0-M3 May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant