Skip to content

Harmonize AOT goal/task names #31918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
snicoll opened this issue Jul 29, 2022 · 2 comments
Closed

Harmonize AOT goal/task names #31918

snicoll opened this issue Jul 29, 2022 · 2 comments
Labels
theme: aot An issue related to Ahead-of-time processing type: enhancement A general enhancement
Milestone
3.0.0-M5

Comments

@snicoll
Copy link
Member

snicoll commented Jul 29, 2022

The maven plugin is currently named spring-boot:aot-generate and The Gradle task is generateAotSources. While brainstorming on the names to use for the related test support, we thought renaming those was in order.

  • For Maven: spring-boot:aot (andspring-boot:aot-test)
  • For Gradle: bootAot (and bootAotTest)
@snicoll snicoll added type: enhancement A general enhancement theme: aot An issue related to Ahead-of-time processing labels Jul 29, 2022
@snicoll snicoll added this to the 3.0.0-M5 milestone Jul 29, 2022
@snicoll snicoll self-assigned this Jul 29, 2022
snicoll added a commit to snicoll/spring-boot that referenced this issue Jul 29, 2022
@snicoll
Rename Maven goal from aot-generate to aot
1f9f670 
See spring-projectsgh-31918
snicoll added a commit to snicoll/spring-boot that referenced this issue Jul 29, 2022
@snicoll
Rename Gradle task from generateAotSources to bootAot
88832e1 
See spring-projectsgh-31918
@snicoll
Copy link
Member Author

snicoll commented Jul 29, 2022

@wilkinsona mentioned that it feels the current proposal uses aot as a verb. We've been brainstorming and found processAot and processTestAot to match nicely with Gradle's compileJava and compileTestJava

@snicoll snicoll removed their assignment Aug 18, 2022
@snicoll snicoll mentioned this issue Aug 18, 2022
Closed
4 tasks
@philwebb
Copy link
Member

At least for now we're going to go with...

Maven:

spring-boot:process-aot
spring-boot:process-test-aot

Gradle:

bootProcessAot
bootProcessTestAot

philwebb added a commit that referenced this issue Aug 25, 2022
@philwebb
Rename 'aot-generate' goal to process-aot'
2f6354f 
See gh-31918
philwebb added a commit that referenced this issue Aug 25, 2022
@philwebb
Rename 'generateAotSources' task to processAot'
c0b3d36 
See gh-31918
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
theme: aot An issue related to Ahead-of-time processing type: enhancement A general enhancement
Projects
None yet
Milestone
3.0.0-M5
Development

No branches or pull requests
2 participants
@snicoll @philwebb