Skip to content

Add classifiers to Managed Dependency Coordinates documentation #34060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
scottfrederick opened this issue Feb 3, 2023 · 1 comment
Closed
Labels
status: declined A suggestion or change that we don't feel we should currently apply type: documentation A documentation update

Comments

@scottfrederick
Copy link
Contributor

A few managed dependencies include one or more classifier along with the group ID, artifact ID, and version coordinates, but the classifiers are not included in the Managed Dependency Coordinates section of the documentation.

In the interest of space, we should avoid adding a new column to the table that will be empty for all but a few dependencies. We could add any classifiers to the Artifact ID or Version column, changing the column title to Artifact ID (Classifiers) or Version (Classifiers) and putting any classifiers in parenthesis in the appropriate rows in that column.

@scottfrederick scottfrederick added the type: documentation A documentation update label Feb 3, 2023
@scottfrederick scottfrederick added this to the 2.7.x milestone Feb 3, 2023
@wilkinsona wilkinsona self-assigned this Oct 30, 2023
@wilkinsona
Copy link
Member

I'm not sure that this is possible, at least not without a change in approach.

We currently use Gradle's variant metadata and dependency constraint metadata to obtain the list of managed versions. This gives us access to the dependency versions that are managed directly in spring-boot-dependencies as well as those that are managed in boms that we import but it does not, as far as I can tell, provide any information about classifiers.

To gather information about classifiers I think we'd have to resolve the imported boms ourselves so that we could extract their dependency management and any version constraints. While I think this may be technically possible I'm not sure that the benefit of documenting classifiers justifies the additional complexity.

@wilkinsona wilkinsona removed their assignment Oct 30, 2023
@wilkinsona wilkinsona added the status: declined A suggestion or change that we don't feel we should currently apply label Oct 30, 2023
@wilkinsona wilkinsona removed this from the 2.7.x milestone Oct 30, 2023
@wilkinsona wilkinsona closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply type: documentation A documentation update
Projects
None yet
Development

No branches or pull requests

2 participants