-
Notifications
You must be signed in to change notification settings - Fork 41.1k
Autoconfigure and QueryDSL #40965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Spring Boot itself doesn't do anything with <dependency>
<groupId>com.querydsl</groupId>
<artifactId>querydsl-jpa</artifactId>
<classifier>jakarta</classifier>
<version>${querydsl}</version>
<optional>true</optional>
</dependency> Can you please describe the problem that you faced in some more detail? Right now, I don't think we have enough information to identify what should be changed or where that change needs to happen. |
Wow that was a quick reply. I was trying to import querydsl directly in my gradle project.
Additionally, I was also referring to this dependency versions doc which doesnt mention the jakarta release of the thing. Might be a miss? There was also a bug from someone who ended up hinting me at what was wrong https://stackoverflow.com/questions/74756871/spring-boot-3-with-querydsl Anyway, my issue is solved but i would like to just add this in somewhere so that someone else doesn't face the same struggles |
It's not Spring Boot's auto-configuration that allows you to omit the versions, it's Spring Boot's dependency management. In the case of your sample project, it's being applied through dependency management plugin but you'd see the same behaviour if you used Gradle's platform support.
It's to be expected that this does not get you the Jakarta version as you have told Gradle that you want the standard non-classified variant. You'd see the same behaviour with Maven if you declared the dependency without a classifier. Whether you're using the dependency management plugin or Gradle's platform support, you need to specify the classifier when declaring the dependency. The answers on Stack Overflow touch on this, but they're all more verbose than needed. You can use this syntax to declare a classifier while allowing the version to be controlled separately:
Note the
We wanted to include the classifier information in the documentation but, unfortunately, it wasn't possible to do so in a way that would be scalable and maintainable for the number of dependencies that Boot manages. Given that Spring Boot itself doesn't do anything with querydsl-jpa, there isn't really a natural place in the documentation to mention the need for the classifier. I think it would be better to document it in Spring Data JPA's documentation where there's an existing section on QueryDSL. If you would like to see that happen, please open a Spring Data JPA issue. |
This isn't completely accurate. It does define the querydsl-bom, which in turn defines querydsl-jpa without the jakarta classifier. This was last updated to 5.1 here as part of the Spring Boot 3.3.0 release. This is actually causing us some very confusing pain. We were already manually defining |
I spent most of my week trying to figure this out. It was genuinely very frustrating.
Spring boot 3 does not support
javax.persistence
APIs and has migrated tojakarta.persistence
.But for some darned reason we import
com.querydsl:querydsl-apt:5.0.0
andcom.querydsl:querydsl-jpa:5.0.0
instead of their jakarta support versions --com.querydsl:querydsl-apt:5.0.0:jakarta
,com.querydsl:querydsl-jpa:5.0.0:jakarta
Please update this or tell me where i can go to raise a PR for this in the autoconfigure plugin.
The text was updated successfully, but these errors were encountered: