Add "stop" goal for the spring-boot-maven-plugin

[matsev]

It would be useful if a stop goal was added to the spring-boot-maven-plugin. This would make it possible to start the Spring Boot application in Maven's pre-integration-test phase and shut it down in the post-integration-test phase when implementing integration tests using the maven-failsafe-plugin.

Example usage:

<plugins>
    <plugin>
        <groupId>org.springframework.boot</groupId>
        <artifactId>spring-boot-maven-plugin</artifactId>
        <executions>
            <execution>
            <id>start-boot</id>
            <phase>pre-integration-test</phase>
            <goals>
                <goal>run</goal>
            </goals>
            </execution>
            <execution>
                <id>stop-boot</id>
                <phase>post-integration-test</phase>
                <goals>
                    <goal>stop</goal>
                </goals>
                </execution>
        </executions>
    </plugin>
    <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-failsafe-plugin</artifactId>
        <version>2.17</version>
        <executions>
            <execution>
                <id>integration-test</id>
                <goals>
                    <goal>integration-test</goal>
                </goals>
            </execution>
            <execution>
                <id>verify</id>
                <goals>
                    <goal>verify</goal>
                </goals>
            </execution>
        </executions>
    </plugin>
    <!-- more plugins -->
</plugins>

Currently, the since there is no stop goal, Spring Boot has to be terminated manually after the integration tests have been completed.

Compare with the jetty and maven-failsafe configuration.

[seanmmills]

This addition would be useful. Maybe a start goal with no thread join and allowing a specified spring-boot artifact so that a separate maven project could hold integration tests.

[snicoll]

we may want to check what the cargo plugin does in that area because it has a lot of maturity.

[seanmmills]

The cargo-maven-plugin came to mind, however, a more pure spring-boot application may be a nicer fit. Especially considering war provided scope issues described in #674, #649, and #650.

[snicoll]

I didn't intend that you should look into using the cargo-maven-plugin. What I meant was that the plugin has options and names for the various goals that are really mature now (as lots of users came with feedback) so we should look at it when implementing a boot equivalent. Sorry if it wasn't clear.

[matsev]

Second thought, I found a workaround using the @IntegrationTest and the @SpringApplicationConfiguration (where I use the same value for the classes attribute as configured in the <start-class> Maven property) that can be used during integration tests. I was not aware of this solution when I created this issue, and it makes the addition of a stop goal somewhat redundant.

[snicoll]

I think it would. I suggest to document this approach properly so that others can find this out easily and resolve this one. We can revisit that later if necessary.

[lucboutier]

Hi, I think that @IntegrationTEST is not good enough as you may want to run other kind of tests than java based (I have an AngularJS ui and uses protractor for testing the app).
So having cargo like start/stop for the plugin would be useful.

[snicoll]

Please create a new issue, this one is closed.