Skip to content

Upgrade to maven-assembly-plugin to 3.1 + #7513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
philwebb opened this issue Nov 29, 2016 · 4 comments
Closed

Upgrade to maven-assembly-plugin to 3.1 + #7513

philwebb opened this issue Nov 29, 2016 · 4 comments
Assignees
@snicoll
Labels
type: dependency-upgrade A dependency upgrade
Milestone
2.0.0.M4

Comments

@philwebb
Copy link
Member

See #7226 and commit 4f7fffb.

Unfortunately the assembly plugin is currently broken due to codehaus-plexus/plexus-archiver#53
@philwebb philwebb added this to the 1.5.0 RC1 milestone Nov 29, 2016
philwebb added a commit that referenced this issue Nov 29, 2016
@philwebb
Downgrade maven-assembly-plugin to 2.6
068a38f 
Downgrade `maven-assembly-plugin` from 3.0 to 2.6 since the later
version contains a bug that means `recompressZippedFiles` is not
respected.

See gh-7513
@philwebb philwebb modified the milestones: 1.5.0 RC1, 1.5.0 M1, 1.5.0 Dec 20, 2016
@wilkinsona
Copy link
Member

wilkinsona commented Jan 20, 2017 •
edited
Loading

This is a bit of a mess. The required version of Commons Compress is out, but it appears to require Java 7. That's holding up a PR to fix the Plexus Archiver issue. I doubt we're going to get this into 1.5, and perhaps wouldn't even want to if it cut off Java 6 support for users of the assembly plugin.

@wilkinsona wilkinsona added the status: blocked An issue that's blocked on an external project change label Jan 20, 2017
@wilkinsona wilkinsona removed this from the 1.5.0 milestone Jan 25, 2017
@michael-o
Copy link

Maven and Plexus developer here. The previous comment by @wilkinsona is treated very seriously, at least by me. There are too many consequences. I will try to raise other devs' attention. You might want to raise an issue with Commons Compress reverting this change for now.

@philwebb
Copy link
Member Author

Thanks @michael-o! We'll probably need to stick with the older version for Spring Boot 1.5. Spring Boot 2.0 is going to require Java 8 anyway, so the Java 7 Commons Compress issue won't matter so much then.

@wilkinsona wilkinsona added type: dependency-upgrade A dependency upgrade and removed type: enhancement A general enhancement labels Mar 24, 2017
@snicoll snicoll mentioned this issue Jun 27, 2017
Closed
@philwebb philwebb added this to the 2.0.0.M4 milestone Jun 28, 2017
@wilkinsona wilkinsona changed the title Upgrade to maven-assembly-plugin to 3.0+ Upgrade to maven-assembly-plugin to 3.1 + Jul 27, 2017
@snicoll snicoll self-assigned this Aug 12, 2017
@snicoll
Copy link
Member

snicoll commented Aug 14, 2017

The vote to release maven-assembly-plugin 3.1.0 has started.

@snicoll snicoll removed the status: blocked An issue that's blocked on an external project change label Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
type: dependency-upgrade A dependency upgrade
Projects
None yet
Milestone
2.0.0.M4
Development

No branches or pull requests
4 participants
@snicoll @philwebb @michael-o @wilkinsona