Skip to content

[WIP] Jetty HTTP2 Support #10041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

olamy
Copy link
Contributor

@olamy olamy commented Aug 18, 2017

This pr had Jetty HTTP2 support for the project.
Still WIP as I'm not sure what is your preferences in term of configuration..
Have a look at the new bean Http2.
Let me know. Then I will add unit test etc..
A sample project is available here https://github.com/olamy/jetty-http2-springboot

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 18, 2017
@bclozel
Copy link
Member

bclozel commented Aug 18, 2017

Hi @olamy, thanks a lot for this PR; as you can see in #10043, we have quite a few contributions already and we first need to figure out a global approach before we can resume with those.

As far as I understand, Jetty is using a Java agent to avoid doing the whole boot classpath thing. I'm not aware of any other solution involving something like native bindings. Am I right?

Feel free to comment on #10043 - thanks!

@philwebb philwebb added the status: on-hold We can't start working on this issue yet label Aug 20, 2017
@olamy
Copy link
Contributor Author

olamy commented Aug 21, 2017

Hi @bclozel
Correct Jetty doesn't need any native binding.
You can find some details here: https://www.eclipse.org/jetty/documentation/current/alpn-chapter.html
The agent (https://github.com/jetty-project/jetty-alpn-agent) is a convenient way for users as it will choose automatically the correct alpn boot to use otherwise users need to download the version depending on their java version.

@bclozel
Copy link
Member

bclozel commented Nov 3, 2017

Jetty is about to support native bindings with Conscrypt, which avoids messing with the boot classpath and using a Java agent - much more in line with the usual java -jar Spring Boot experience.

We'll definitely cherry-pick things from this PR. Thanks @olamy !

Closing this in favor of #10902

@bclozel bclozel closed this Nov 3, 2017
@snicoll snicoll removed the status: waiting-for-triage An issue we've not yet triaged label Nov 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: on-hold We can't start working on this issue yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants