fix possible resource leaks #11624
Closed
fix possible resource leaks #11624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@igor-suhorukov Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@igor-suhorukov Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
|
@philwebb looking at this one, I am a bit surprised about this polish commit. Can you expand why you've removed this call to |
|
Do you use Continuous Code Quality tools like SonarQube in CI build? |
|
@snicoll No idea 🤷♂️ It was in 2016. Looks like a mistake. |
@igor-suhorukov We have checkstyle rules but we don't have SonarQube. I've raised #11650. |
snicoll
approved these changes
Jan 17, 2018
snicoll
added
type: task
snicoll
pushed a commit
that referenced
this pull request
Jan 17, 2018
snicoll
added a commit
that referenced
this pull request
Jan 17, 2018
* pr/11624: Polish "Fix potential resource leaks" Fix potential resource leaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is focused on resolving occurrences of Sonar rule squid:S2095 - Use try-with-resources or close this
I inspect Spring Boot code with sonarcloud.io and found some issues. Try to fix some blocker issues from #11623