Skip to content

fix generic type constraint issues and try to avoid issues covered by SonarQube squid:S1452 rule #11709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix generic type constraint issues and try to avoid issues covered by SonarQube squid:S1452 rule #11709

wants to merge 1 commit into from

Conversation

igor-suhorukov
Copy link
Contributor

fix generic type constraint issues and try to avoid "Generic wildcard types should not be used in return parameters" SonarQube squid:S1452 rule

related to #11650

@igor-suhorukov
fix generic type constraint issues and try to avoid "Generic wildcard…
d9ff26d 
… types should not be used in return parameters" SonarQube squid:S1452 rule
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 21, 2018
@philwebb
Copy link
Member

Thanks for the suggestions, but overall I'm not sure that these edits really improve the codebase.

The change in ConditionMessage that returns a Collection rather than Collection<?> seems wrong, and most of the others are covered implicitly. For example DataSourceProperties currently returns a DataSourceBuilder<?>, the change to DataSourceBuilder<? extends DataSource> feels noisy given that the builder is already typed as DataSourceBuilder<T extends DataSource>.

Thanks anyway.

@philwebb philwebb closed this Jan 22, 2018
@philwebb philwebb added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igor-suhorukov @philwebb @spring-projects-issues