Add loadOnStartup attribute to @EndpointServlet
#16053
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loadOnStartup property was missing from EndpointServlet and cannot be set inside ServletEndpointRegistrar. Now it can be set and register a Servlet with that integer property ready to act upon registration Fixes spring-projects#15672
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
added
type: enhancement
It was importing ServletRegistration and it is not needed. Refers to spring-projects#16053
|
I removed an unused import in EndpointServlet. |
|
@wilkinsona It seems that the concourse build failed because of changes in hateoas module (not made by my commits). It will be marked OK in following builds or is any further action required by me? |
|
There were some breaking API changes in recent HATEOAS snapshots. We've adapted to them on master now. No need for you to take any further action. We'll rebase your changes prior to merging them. Thanks for asking. |
snicoll
pushed a commit
that referenced
this pull request
Mar 5, 2019
loadOnStartup property was missing from EndpointServlet and cannot be set inside ServletEndpointRegistrar. Now it can be set and register a Servlet with that integer property ready to act upon registration. See gh-16053
snicoll
added a commit
that referenced
this pull request
Mar 5, 2019
* pr/16053: Polish "Add loadOnStartup property to EndpointServlet" Add loadOnStartup property to EndpointServlet
|
@juliojgd thank you very much for making your first contribution to Spring Boot. This work is now merged in |
|
@snicoll Thank you very much for your review. I hope I will be contributing again. :) |
wilkinsona
changed the title
@EndpointServlet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loadOnStartup property was missing from EndpointServlet and cannot
be set inside ServletEndpointRegistrar. Now it can be set and register
a Servlet with that integer property ready to act upon registration
Fixes #15672