Simplify if statements #17785
Closed
Simplify if statements #17785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s can be simplified, so I submitted this pull request.
|
@SaberMaycry Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@SaberMaycry Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
mbhave
changed the title
mbhave
reviewed
Aug 5, 2019
.../src/main/java/org/springframework/boot/gradle/tasks/bundling/LaunchScriptConfiguration.java
Outdated
Show resolved
Hide resolved
mbhave
added
type: task
mbhave
added
the
status: waiting-for-feedback
snicoll
removed
the
status: waiting-for-feedback
snicoll
pushed a commit
that referenced
this pull request
Aug 8, 2019
snicoll
added a commit
that referenced
this pull request
Aug 8, 2019
|
@SaberMaycry thank you for making your first contribution to Spring Boot. I've decided to revert a couple of changes when there are several if statements in a row as I prefer the readability even if the last statement can be simplified. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I read the source code with IDEA, I found that some statements can be simplified, so I submitted this pull request.