Skip to content

Fix deprecation info in CompositeHealthIndicatorConfiguration #19180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

dreis2211
Copy link
Contributor

Hi,

I wanted to do a PR that removes code marked as deprecated since 2.0.x and 2.1.x when I found one occurrence in CompositeHealthIndicatorConfiguration that seems to state the wrong release in its deprecation info.

Cheers,
Christoph

P.S.: Are you generally okay with one single follow up PR that removes the 3 places that seem to be deprecated since 2.1.x?

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 28, 2019
@snicoll snicoll added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 28, 2019
@snicoll snicoll self-assigned this Nov 28, 2019
@snicoll snicoll added this to the 2.2.2 milestone Nov 28, 2019
@snicoll snicoll closed this in ea43165 Nov 28, 2019
@snicoll
Copy link
Member

snicoll commented Nov 28, 2019

Are you generally okay with one single follow up PR that removes the 3 places that seem to be deprecated since 2.1.x?

At this point, I think we could do with one pass of deprecated code in 2.2.x (or before) that hasn't been removed on master. I don't see why we've missed those when we started working on 2.2.x. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants