-
Notifications
You must be signed in to change notification settings - Fork 41.1k
Add smoke tests for Spring Session Redis/Mongo #28362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR, @avillalain. Instead of the embedded servers we might be able to use Regarding the |
Sure I can update the PR to account for the test containers, I saw some others were using the embedded approach and ended up following that route to keep consistency. I'll update the PR tomorrow with those changes. I'll look into what you are point out for the web session too. Thanks |
There's no Actuator integration for |
That explains why it wasn't working in my tests, I didn't know about that but I remember seeing some comments around this in some other issues, thanks, I'll deal with the changes to include Test containers instead of the embedded approach. I don't have that much experience on the reactive side of things |
@vpavic also is there an issue for the web session integration? |
There's #10827 but it's blocked until Spring Session provides the reactive equivalent of |
Thanks @vpavic! I'd forgotten about that issue! |
Add smoke tests that verify the correct behavior of the sessions endpoint when using Spring Session with MongoDB and Redis. See spring-projectsgh-28291
Remove the usage of embedded mongo and redis in favor of test containers
Thanks @mbhave for all the feedback provided, I finished updating the PR. It is now using test containers. Quick question @vpavic is the issue you mentioned something complicated, would it be a suitable first timer kind of issue? I basically am fishing for another issue considering this is done in case there are no additional feedback. @mbhave In case the issue is not suitable for a first timer, what could be another issue I could grab? Thanks for your help and support |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Add smoke tests that verify the correct behavior of the sessions endpoint when using Spring Session with MongoDB and Redis. See gh-28362
@avillalain Thanks for making your first contribution to Spring Boot. This has been merged into |
Add smoke tests that verify the correct behavior of the sessions
endpoint when using Spring Session with MongoDB and Redis.
See gh-28291