-
Notifications
You must be signed in to change notification settings - Fork 41.2k
Configuration properties for Statsd's buffered and step properties are missing #30898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks, @izeye. It's a shame that we missed this. I've opened #30901 to see if we can stop if from happening again. There is a workaround for the missing property, but it's not very elegant:
As such, I am a bit tempted to treat this as a bug and fix it in 2.5.x. Flagging for team attention to see what everyone else thinks. |
I think it's reasonable to consider this a bug of omission. |
@wilkinsona I don't have much experience working with StatsD, but it seems to have been missed unintentionally, too and it sounds reasonable to align configurability level with its corresponding meter registry configuration. /cc @shakuzen |
Statsd's |
@wilkinsona Sure, I pushed ccbe758 for it. |
Thanks again @izeye |
This PR changes to expose
buffered
property forStatsdConfig
.See micrometer-metrics/micrometer#1375