Skip to content

Make auto-configured Brave Tracer more compliant with OTel tracer #32615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

marcingrzejszczak
Copy link
Contributor

by default we will not support joined spans and the trace id will be 128 bit

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 6, 2022
@wilkinsona
Copy link
Member

Thanks, @marcingrzejszczak. Can you please add tests to BraveAutoConfiguration that assert that the trace IDs are now 128-bit and that joining isn't supported?

@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label Oct 6, 2022
by default we will not support joined spans and the trace id will be 128 bit
@wilkinsona wilkinsona changed the title Makes Brave Tracer more compliant with OTel tracer Make auto-configured Brave Tracer more compliant with OTel tracer Oct 7, 2022
@wilkinsona wilkinsona added type: enhancement A general enhancement and removed status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged labels Oct 7, 2022
@wilkinsona wilkinsona added this to the 3.0.0-RC1 milestone Oct 7, 2022
wilkinsona pushed a commit that referenced this pull request Oct 7, 2022
By default we will not support joined spans and the trace ID will
be 128-bit.

See gh-32615
@wilkinsona wilkinsona closed this in 006d2ed Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants