Using devtools with Reactive application results in slower restarts #33855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored multiple @bean ReactorResourceFactory methods into one
mhalbritter
changed the title
philwebb
added
the
for: team-attention
philwebb
removed
the
for: team-attention
mhalbritter
added
type: bug
mhalbritter
added a commit
that referenced
this pull request
Feb 1, 2023
izeye
added a commit
to izeye/spring-boot
that referenced
this pull request
Feb 9, 2023
krenson
pushed a commit
to krenson/test-push
that referenced
this pull request
Mar 15, 2023
…ot-starter-parent from 2.7.8 to 2.7.9 (patch) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.springframework.boot:spring-boot-starter-parent](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | parent | patch | `2.7.8` -> `2.7.9` | --- ### Release Notes <details> <summary>spring-projects/spring-boot</summary> ### [`v2.7.9`](https://github.com/spring-projects/spring-boot/releases/tag/v2.7.9) [Compare Source](spring-projects/spring-boot@v2.7.8...v2.7.9) #### 🐞 Bug Fixes - Maven Plugin's PropertiesMergingResourceTransformer closes InputStream when it should not do so [#​34063](spring-projects/spring-boot#34063) - Actuator Health web endpoint broken with Gson and Java 17 [#​34030](spring-projects/spring-boot#34030) - Dependency management for Mongo's Java Driver is incomplete [#​33941](spring-projects/spring-boot#33941) - Using devtools with Reactive application results in slower restarts [#​33855](spring-projects/spring-boot#33855) - Spies are not reset after test execution when using `@SpyBean` [#​33830](spring-projects/spring-boot#33830) - Properties Migrator does not detect properties of Map type that are marked as deprecated [#​27854](spring-projects/spring-boot#27854) #### 📔 Documentation - Updated documentation for `@ConfigurationProperties` bean naming rules [#​34029](spring-projects/spring-boot#34029) - Restore "Use Jedis Instead of Lettuce" how-to documentation [#​33994](spring-projects/spring-boot#33994) - Add Redis application properties example [#​33965](spring-projects/spring-boot#33965) - Use Maven Central for release downloads in CLI installation documentation [#​33962](spring-projects/spring-boot#33962) - Actuator section is missing from documentation overview [#​33932](spring-projects/spring-boot#33932) - Add Javadoc since to OperationParameter.getAnnotation() [#​33914](spring-projects/spring-boot#33914) - Document additional configuration that is required for spring.mvc.throw-exception-if-no-handler-found=true to be effective [#​31660](spring-projects/spring-boot#31660) #### 🔨 Dependency Upgrades - Upgrade to ActiveMQ 5.16.6 [#​34238](spring-projects/spring-boot#34238) - Upgrade to Byte Buddy 1.12.23 [#​34239](spring-projects/spring-boot#34239) - Upgrade to Dropwizard Metrics 4.2.16 [#​34240](spring-projects/spring-boot#34240) - Upgrade to Elasticsearch 7.17.9 [#...
krenson
pushed a commit
to krenson/test-push
that referenced
this pull request
Mar 15, 2023
…ot-starter-parent from 2.7.8 to 2.7.9 (patch) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [org.springframework.boot:spring-boot-starter-parent](https://spring.io/projects/spring-boot) ([source](https://github.com/spring-projects/spring-boot)) | parent | patch | `2.7.8` -> `2.7.9` | --- ### Release Notes <details> <summary>spring-projects/spring-boot</summary> ### [`v2.7.9`](https://github.com/spring-projects/spring-boot/releases/tag/v2.7.9) [Compare Source](spring-projects/spring-boot@v2.7.8...v2.7.9) #### 🐞 Bug Fixes - Maven Plugin's PropertiesMergingResourceTransformer closes InputStream when it should not do so [#​34063](spring-projects/spring-boot#34063) - Actuator Health web endpoint broken with Gson and Java 17 [#​34030](spring-projects/spring-boot#34030) - Dependency management for Mongo's Java Driver is incomplete [#​33941](spring-projects/spring-boot#33941) - Using devtools with Reactive application results in slower restarts [#​33855](spring-projects/spring-boot#33855) - Spies are not reset after test execution when using `@SpyBean` [#​33830](spring-projects/spring-boot#33830) - Properties Migrator does not detect properties of Map type that are marked as deprecated [#​27854](spring-projects/spring-boot#27854) #### 📔 Documentation - Updated documentation for `@ConfigurationProperties` bean naming rules [#​34029](spring-projects/spring-boot#34029) - Restore "Use Jedis Instead of Lettuce" how-to documentation [#​33994](spring-projects/spring-boot#33994) - Add Redis application properties example [#​33965](spring-projects/spring-boot#33965) - Use Maven Central for release downloads in CLI installation documentation [#​33962](spring-projects/spring-boot#33962) - Actuator section is missing from documentation overview [#​33932](spring-projects/spring-boot#33932) - Add Javadoc since to OperationParameter.getAnnotation() [#​33914](spring-projects/spring-boot#33914) - Document additional configuration that is required for spring.mvc.throw-exception-if-no-handler-found=true to be effective [#​31660](spring-projects/spring-boot#31660) #### 🔨 Dependency Upgrades - Upgrade to ActiveMQ 5.16.6 [#​34238](spring-projects/spring-boot#34238) - Upgrade to Byte Buddy 1.12.23 [#​34239](spring-projects/spring-boot#34239) - Upgrade to Dropwizard Metrics 4.2.16 [#​34240](spring-projects/spring-boot#34240) - Upgrade to Elasticsearch 7.17.9 [#...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #29528
This adds a new property named
spring.reactor.netty.shutdown-quiet-periodwhich effectively setsReactorResourceFactory.setShutdownQuietPeriodif notnull.I refactored the 3
@Bean ReactorResourceFactorymethods into a single place.I had to fix one test which expected a bean called
reactorClientResourceFactory, which is due to the refactoring now calledreactorResourceFactory.The devtools bug, which triggered this change, is now easy to fix: Add
spring.reactor.netty.shutdown-quiet-period=0stodevtools-property-defaults.properties.Not sure if we can release this in a patch release. WDYT?