Replace calls to verifyComplete() with expectComplete().verify(Duration) to avoid blocking indefinitely #35915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ThomazPassarelli Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: task
philwebb
changed the title
|
When we merge this we should also consider this comment from the original issue:
|
|
I've got one locally. We should also remove any calls to |
|
@ThomazPassarelli can you please sign the CLA when you have a moment? |
|
@ThomazPassarelli Thank you for signing the Contributor License Agreement! |
wilkinsona
pushed a commit
that referenced
this pull request
Jun 23, 2023
wilkinsona
added a commit
that referenced
this pull request
Jun 23, 2023
|
Thanks very much, @ThomazPassarelli. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the issue #35791, where it was required to replace
verifyComplete()withexpectComplete().verify(Duration)in test cases across multiple files.Changes made:
verifyComplete()withexpectComplete().verify(Duration.ofSeconds(5))in all the necessary places. The decision to useDuration.ofSeconds(5)was influenced by its existing usage in another part of the project, ensuring consistency across the codebase.import java.time.Duration;where it was not already imported.I have successfully made changes to 23 files and built the project without any errors. All the tests ran successfully after the changes.