Change server log message to have "port" or "ports" rather than "ports(s)" #36103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@asashour Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@asashour Thank you for signing the Contributor License Agreement! |
philwebb
added
type: enhancement
wilkinsona
requested changes
Jun 30, 2023
There was a problem hiding this comment.
Thanks for the PR, @asashour. I've left a few comments for your consideration when you have a minute.
...ct/spring-boot/src/main/java/org/springframework/boot/web/embedded/jetty/JettyWebServer.java
Outdated
Show resolved
Hide resolved
.../spring-boot/src/main/java/org/springframework/boot/web/embedded/tomcat/TomcatWebServer.java
Outdated
Show resolved
Hide resolved
...ing-boot/src/main/java/org/springframework/boot/web/embedded/undertow/UndertowWebServer.java
Outdated
Show resolved
Hide resolved
.../spring-boot/src/main/java/org/springframework/boot/web/embedded/tomcat/TomcatWebServer.java
Outdated
Show resolved
Hide resolved
wilkinsona
changed the title
philwebb
added
status: waiting-for-feedback
wilkinsona
removed
the
status: waiting-for-feedback
|
Thanks very much, @asashour. |
wilkinsona
pushed a commit
that referenced
this pull request
Jun 30, 2023
wilkinsona
added a commit
that referenced
this pull request
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some places in the logs, which says
ports(s).I believe it would be better to say only
portorportsaccording to the number of ports, if it is 1, then use the singular form, otherwise use the plural form.