Skip to content

Make spring.config.activate.on-cloud-platform=none match when the current cloud platform is null #38510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Make spring.config.activate.on-cloud-platform=none match when the current cloud platform is null #38510

wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Nov 23, 2023

Fix GH-38506

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 23, 2023
@wilkinsona wilkinsona changed the title Treat ClouldPlatform.NONE as null Make spring.config.activate.on-cloud-platform=none match when the current cloud platform is null Dec 7, 2023
@wilkinsona wilkinsona added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 7, 2023
@wilkinsona wilkinsona added this to the 3.3.x milestone Dec 7, 2023
@wilkinsona wilkinsona mentioned this pull request Dec 7, 2023
Closed
@wilkinsona wilkinsona self-assigned this Jan 5, 2024
@wilkinsona wilkinsona modified the milestones: 3.3.x, 3.3.0-M1 Jan 5, 2024
wilkinsona pushed a commit that referenced this pull request Jan 5, 2024
@quaff @wilkinsona
Treat null as CloudPlatform.NONE
01bb806 
See gh-38510
wilkinsona added a commit that referenced this pull request Jan 5, 2024
@wilkinsona
Polish "Treat null as CloudPlatform.NONE"
c3a5e76 
See gh-38510
@wilkinsona wilkinsona closed this in 77b533b Jan 5, 2024
@wilkinsona
Copy link
Member

Thanks very much, @quaff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wilkinsona wilkinsona

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.3.0-M1
Development

Successfully merging this pull request may close these issues.

spring.config.activate.on-cloud-platform should consider NONE to be semantically equivalent to null
3 participants
@quaff @wilkinsona @spring-projects-issues