Skip to content

Correct references to Jetty's HTTP2 server module #38632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Correct references to Jetty's HTTP2 server module #38632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0dd460e
Update documentation about jetty http2 dependency
gavlyukovskiy Dec 1, 2023
dfd0deb
Also add assert in factory that is used to create http2 connector
gavlyukovskiy Dec 1, 2023
ceed367
Use actual connector factory class
gavlyukovskiy Dec 1, 2023
958fc02
Added missing import
gavlyukovskiy Dec 1, 2023
5b717a1
Revert changes to JettyServletWebServerFactory
gavlyukovskiy Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spring-boot-project/spring-boot-docs/src/docs/asciidoc/howto/webserver.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ More on this in the {tomcat-docs}/apr.html[official Tomcat documentation].

[[howto.webserver.configure-http2.jetty]]
==== HTTP/2 With Jetty
For HTTP/2 support, Jetty requires the additional `org.eclipse.jetty.http2:http2-server` dependency.
For HTTP/2 support, Jetty requires the additional `org.eclipse.jetty.http2:jetty-http2-server` dependency.
To use `h2c` no other dependencies are required.
To use `h2`, you also need to choose one of the following dependencies, depending on your deployment:

Expand Down
2 changes: 1 addition & 1 deletion ...g-boot/src/main/java/org/springframework/boot/web/embedded/jetty/SslServerCustomizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ private ServerConnector createServerConnector(Server server, SslContextFactory.S
Assert.state(isJettyAlpnPresent(),
() -> "An 'org.eclipse.jetty:jetty-alpn-*-server' dependency is required for HTTP/2 support.");
Assert.state(isJettyHttp2Present(),
() -> "The 'org.eclipse.jetty.http2:http2-server' dependency is required for HTTP/2 support.");
() -> "The 'org.eclipse.jetty.http2:jetty-http2-server' dependency is required for HTTP/2 support.");
return createHttp2ServerConnector(config, sslContextFactory, server);
}

Expand Down