-
Notifications
You must be signed in to change notification settings - Fork 41.1k
Update the Debugging Documentation of the Spring Boot Maven Plugin #39392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Should we update the test for parseDebugFlags as well as the running-your-application doc to reflect this change? |
I added another commit for the running-your-application documentation. An updated
I am not really sure if that would make sense as it would be just testing if one argument is parsed correctly which is also tested in e.g. |
Excellent, thank you 💯 It might be worth updating the test to ensure that the parsing works as expected in cases changes are made in the parser in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Thank you very much and congratulations on your first contribution 🎉! |
Replaced the old JVM Argument -Xdebug (which does nothing according to documentation) with newer ones as described in #39388.