Skip to content

Makes it easier to customize a Servlet-based web server's mime mappings #39430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

BenchmarkingBuffalo
Copy link
Contributor

Add a new property called 'mime-mappings' under the 'server' property.
This is a key-value-map, which is added to the default MimeMappings.

If their is a need to adjust the documentation, just hit me up and I will add this.

See #38902

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 7, 2024
@BenchmarkingBuffalo BenchmarkingBuffalo force-pushed the 38902-custom-mime-mappings branch from 07ed2a1 to fdb7570 Compare February 7, 2024 09:52
@wilkinsona
Copy link
Member

Thanks for the PR. Can you please use main as the base branch? This would be a new feature so it won't be included in a maintenance branch.

@BenchmarkingBuffalo BenchmarkingBuffalo force-pushed the 38902-custom-mime-mappings branch from fdb7570 to f383aa1 Compare February 7, 2024 11:42
@BenchmarkingBuffalo BenchmarkingBuffalo changed the base branch from 3.1.x to main February 7, 2024 11:43
Add a new property called 'mime-mappings' under the 'server' property.
This is a key-value-map, which is added to the default MimeMappings.

See spring-projectsgh-38902
@BenchmarkingBuffalo BenchmarkingBuffalo force-pushed the 38902-custom-mime-mappings branch from f383aa1 to e05bb43 Compare February 7, 2024 11:48
@BenchmarkingBuffalo
Copy link
Contributor Author

Sure thing, I rebased it on main and fixed the conflicts.
closes #38902

@scottfrederick scottfrederick added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 7, 2024
@scottfrederick scottfrederick added this to the 3.3.x milestone Feb 7, 2024
mhalbritter pushed a commit that referenced this pull request Feb 8, 2024
Add a new property called 'mime-mappings' under the 'server' property.
This is a key-value-map, which is added to the default MimeMappings.

See gh-39430
@mhalbritter
Copy link
Contributor

Thanks a lot!

@mhalbritter mhalbritter modified the milestones: 3.3.x, 3.3.0-M2 Feb 8, 2024
@wilkinsona wilkinsona changed the title Add possibility for custom MimeMappings Makes it easier to customize a Servlet-based web server's mime mappings Feb 8, 2024
@mhalbritter mhalbritter self-assigned this Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants