Re-order route registration for GraphQL WebMvc / WebFlux #39613
Closed
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-order the route registrations for GraphQL requests so that the most commonly matched path is evaluated first.
spring-projects-issues
added
the
status: waiting-for-triage
bclozel
added
type: task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-order the route registrations for GraphQL requests so that the most commonly matched path is evaluated first.
The common case is valid POST requests to the graphql endpoint, so add that handler first; we found there is some overhead in the request predicate evaluation (see this issue), so while it may seem like a micro-optimization, it's a trivial change and can avoid evaluating some predicates in the common case.